From: Marek Polacek <mpolacek@redhat.com>
To: "gdb-patches@sourceware.org" <gdb-patches@sourceware.org>
Subject: [PATCH] gdb.python/py-evthreads.exp: fix racy test (PR testsuite/12649)
Date: Tue, 28 Jun 2011 14:19:00 -0000 [thread overview]
Message-ID: <4E09E2C1.2020909@redhat.com> (raw)
This test fails with read1() because after sending "continue&"
the regexp with ".*" at the end didn't eat all that it ought to.
This causes trouble later on. Thusly fixed by adding the "\r\n$gdb_prompt".
Tested with both read{,1}. OK?
2011-06-28 Marek Polacek <mpolacek@redhat.com>
* gdb.python/py-evthreads.exp: Fix race by adding an anchor to match
the whole output.
--- gdb/gdb/testsuite/gdb.python/py-evthreads.exp.mp 2011-06-22 15:14:07.869452151 +0200
+++ gdb/gdb/testsuite/gdb.python/py-evthreads.exp 2011-06-28 16:10:53.157450752 +0200
@@ -86,7 +86,7 @@ gdb_expect {
send_gdb "continue&\n"
gdb_expect {
-re ".*event type: continue.*
-.*thread num: 1.*" {
+.*thread num: 1.*\r\n$gdb_prompt" {
pass "continue thread 1"
}
timeout {
next reply other threads:[~2011-06-28 14:19 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-28 14:19 Marek Polacek [this message]
2011-06-28 15:51 ` Joel Brobecker
2011-06-30 10:26 ` Marek Polacek
2011-07-06 17:21 ` Jan Kratochvil
2011-07-06 17:32 ` Joel Brobecker
2011-07-06 17:57 ` Marek Polacek
2011-07-06 19:53 ` Jan Kratochvil
2011-07-06 22:06 ` Marek Polacek
2011-07-06 14:36 ` Marek Polacek
2011-07-06 14:51 ` Joel Brobecker
2011-07-06 15:46 ` Marek Polacek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E09E2C1.2020909@redhat.com \
--to=mpolacek@redhat.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox