From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 4402 invoked by alias); 6 Jul 2011 17:12:21 -0000 Received: (qmail 4382 invoked by uid 22791); 6 Jul 2011 17:12:20 -0000 X-SWARE-Spam-Status: No, hits=-6.4 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,SPF_HELO_PASS,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 06 Jul 2011 17:12:01 +0000 Received: from int-mx01.intmail.prod.int.phx2.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id p66HBmcH006818 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Wed, 6 Jul 2011 13:11:48 -0400 Received: from host1.jankratochvil.net (ovpn-113-91.phx2.redhat.com [10.3.113.91]) by int-mx01.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id p66HBk3I015909 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Wed, 6 Jul 2011 13:11:48 -0400 Received: from host1.jankratochvil.net (localhost [127.0.0.1]) by host1.jankratochvil.net (8.14.4/8.14.4) with ESMTP id p66HBjKt002846; Wed, 6 Jul 2011 19:11:45 +0200 Received: (from jkratoch@localhost) by host1.jankratochvil.net (8.14.4/8.14.4/Submit) id p66HBjFV002845; Wed, 6 Jul 2011 19:11:45 +0200 Date: Wed, 06 Jul 2011 17:21:00 -0000 From: Jan Kratochvil To: Marek Polacek Cc: Joel Brobecker , "gdb-patches@sourceware.org" Subject: Re: [PATCH] gdb.python/py-evthreads.exp: fix racy test (PR testsuite/12649) Message-ID: <20110706171145.GB28535@host1.jankratochvil.net> References: <4E09E2C1.2020909@redhat.com> <20110628155107.GL20676@adacore.com> <4E0C4F28.4000703@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4E0C4F28.4000703@redhat.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2011-07/txt/msg00203.txt.bz2 On Thu, 30 Jun 2011 12:25:44 +0200, Marek Polacek wrote: > On 06/28/2011 05:51 PM, Joel Brobecker wrote: > > This is an area where I'm not entirely sure, but we usually use > > `$gdb_prompt $' as the anchor. > > Actually, it doesn't matter. That `$' at the end marks end of the > read buffer, not the end of line. It is a difference as it requires the end of the read buffer that way. If GDB outputs some (gdb) unexpected_result then (without any read1 hacks) -re "$gdb_prompt $" will FAIL/timeout as it should while -re "$gdb_prompt " could give a false PASS. (I do not think it requires a new commit, it is up to you.) Thanks, Jan