From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 12997 invoked by alias); 6 Jul 2011 17:42:46 -0000 Received: (qmail 12980 invoked by uid 22791); 6 Jul 2011 17:42:45 -0000 X-SWARE-Spam-Status: No, hits=-6.9 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,SPF_HELO_PASS,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 06 Jul 2011 17:42:32 +0000 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id p66HgH7L020711 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Wed, 6 Jul 2011 13:42:17 -0400 Received: from dhcp-25-89.brq.redhat.com (vpn-10-25.rdu.redhat.com [10.11.10.25]) by int-mx09.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id p66HgF5q007640; Wed, 6 Jul 2011 13:42:16 -0400 Message-ID: <4E149E77.3040608@redhat.com> Date: Wed, 06 Jul 2011 17:57:00 -0000 From: Marek Polacek User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.2.9) Gecko/20100827 Red Hat Thunderbird/3.1.3 MIME-Version: 1.0 To: Joel Brobecker CC: Jan Kratochvil , "gdb-patches@sourceware.org" Subject: Re: [PATCH] gdb.python/py-evthreads.exp: fix racy test (PR testsuite/12649) References: <4E09E2C1.2020909@redhat.com> <20110628155107.GL20676@adacore.com> <4E0C4F28.4000703@redhat.com> <20110706171145.GB28535@host1.jankratochvil.net> <20110706172616.GE2407@adacore.com> In-Reply-To: <20110706172616.GE2407@adacore.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2011-07/txt/msg00207.txt.bz2 On 07/06/2011 07:26 PM, Joel Brobecker wrote: >> It is a difference as it requires the end of the read buffer that way. >> >> If GDB outputs some >> (gdb) unexpected_result >> >> then (without any read1 hacks) -re "$gdb_prompt $" will FAIL/timeout as it >> should while -re "$gdb_prompt " could give a false PASS. >> >> (I do not think it requires a new commit, it is up to you.) > > Let's fix it. If anything, we should be consistent. I might have > a minute later today, but I don't want to make the change without > running the testcase... So, I won't mind if someone gets to it before > I do. > Sure. Shall I commit the patch below? 2011-07-06 Marek Polacek * gdb.python/py-evthreads.exp: Add missing `$'. --- gdb/gdb/testsuite/gdb.python/py-evthreads.exp.mp 2011-07-06 19:34:05.210582529 +0200 +++ gdb/gdb/testsuite/gdb.python/py-evthreads.exp 2011-07-06 19:34:14.660516229 +0200 @@ -86,7 +86,7 @@ gdb_expect { send_gdb "continue&\n" gdb_expect { -re ".*event type: continue.* -.*thread num: 1.*\r\n$gdb_prompt " { +.*thread num: 1.*\r\n$gdb_prompt $" { pass "continue thread 1" } timeout {