[patch 0/2] Fixes to gdb.base/dump.exp

[patch 0/2] Fixes to gdb.base/dump.exp

[Yao Qi]

In current gdb.base/dump.exp, there are 3 gdb sessions started one by
one, and assuming that symbol addresses doesn't change among these 3 gdb
sessions.  However, it is not true on non-MMU processor running uclinux.

In order to make it easier to review my two patches, I'd like to
describe what dump.exp does first.  In dump.exp, gdb is started three times,

  - 1 Start gdb, and run to checkpoint1.  Dump memory into files of
different formats.
  - 2 Start gdb, and reload these dump files.  Compare results in dump
files are same as them in memory.
  - 3 Start gdb, and restore these dump files.  Compare results in dump
files are the same them in memory.

-- 
Yao (齐尧)

[patch 1/2] Fixes to gdb.base/dump.exp: get value from address instead of name

[Yao Qi]

[-- Attachment #1: Type: text/plain, Size: 910 bytes --]

On 06/21/2011 06:42 PM, Yao Qi wrote:
>   - 2 Start gdb, and reload these dump files.  Compare results in dump
> files are same as them in memory.

In session 2, memory contents are looked for by symbols names.  However,
the address of the same symbol may be on different addresses in session
1 and session 2, so many tests will fail.

This patch is to fix these fails in this way.  In gdb session 1, when
dump file is being produced, get the address of struct and array, along
with their type.  In gdb session 2, when dump file is loaded, look for
memory contents via address we recorded in session 1.

IMO, the intention of tests in this gdb session is to test that "gdb is
able to load these dump files, and read the correct memory contents from
them", so it doesn't matter too much that gdb get them via name or
address.  I think the semantics of this part of tests is not changed.

-- 
Yao (齐尧)

[-- Attachment #2: 0015-fix-for-test_reload_saved_value.patch --]
[-- Type: text/x-patch, Size: 3694 bytes --]

2011-06-21  Yao Qi  <yao@codesourcery.com>

	gdb/testsuite/
	* gdb.base/dump.exp (capture_value_with_type): New.
	Get value from address instead of name.

---
 gdb/testsuite/gdb.base/dump.exp |   46 ++++++++++++++++++++++++++++----------
 1 files changed, 34 insertions(+), 12 deletions(-)

diff --git a/gdb/testsuite/gdb.base/dump.exp b/gdb/testsuite/gdb.base/dump.exp
index 1f307f4..7042abc 100644
--- a/gdb/testsuite/gdb.base/dump.exp
+++ b/gdb/testsuite/gdb.base/dump.exp
@@ -152,6 +152,25 @@ proc capture_value { expression args } {
     return $output_string
 }
 
+proc capture_value_with_type { expression } {
+    global gdb_prompt
+    global expect_out
+
+    set test "capture type of $expression"
+    set output_string ""
+    gdb_test_multiple "p ${expression}" $test {
+	-re "\\$\[0-9\]+ = .*$gdb_prompt $" {
+	    if [regexp { \(.*\).*[0-9]+} $expect_out(0,string) output_string] {
+		pass "$test $output_string"
+	    } else {
+		fail "$test unable to match regexp"
+	    }
+	}
+    }
+
+    return $output_string
+}
+
 set array_start  [capture_value "/x &intarray\[0\]"]
 set array_end    [capture_value "/x &intarray\[32\]"]
 set struct_start [capture_value "/x &intstruct"]
@@ -160,6 +179,9 @@ set struct_end   [capture_value "/x &intstruct + 1"]
 set array_val    [capture_value "intarray"]
 set struct_val   [capture_value "intstruct"]
 
+set array_ptr_type [capture_value_with_type "&intarray"]
+set struct_ptr_type [capture_value_with_type "&intstruct"]
+
 make_dump_file "dump mem intarr2.bin $array_start $array_end" \
 	"dump array as memory, default"
 
@@ -255,38 +277,38 @@ proc test_restore_saved_value { restore_args msg oldval newval } {
 # srec format can not be loaded for 64-bit-only platforms
 if ![string compare $is64bitonly "no"] then {
   test_reload_saved_value "intarr1.srec" "reload array as value, srec" \
-	$array_val "intarray"
+	$array_val "\*$array_ptr_type"
   test_reload_saved_value "intstr1.srec" "reload struct as value, srec" \
-	$struct_val "intstruct"
+	$struct_val "\*$struct_ptr_type"
   test_reload_saved_value "intarr2.srec" "reload array as memory, srec" \
-	$array_val "intarray"
+	$array_val "\*$array_ptr_type"
   test_reload_saved_value "intstr2.srec" "reload struct as memory, srec" \
-	$struct_val "intstruct"
+	$struct_val "\*$struct_ptr_type"
 }
 
 # ihex format can not be loaded for 64-bit-only platforms
 if ![string compare $is64bitonly "no"] then {
 
   test_reload_saved_value "intarr1.ihex" "reload array as value, intel hex" \
-	$array_val "intarray"
+	$array_val "\*$array_ptr_type"
   test_reload_saved_value "intstr1.ihex" "reload struct as value, intel hex" \
-	$struct_val "intstruct"
+	$struct_val "\*$struct_ptr_type"
   test_reload_saved_value "intarr2.ihex" "reload array as memory, intel hex" \
-	$array_val "intarray"
+	$array_val "\*$array_ptr_type"
   test_reload_saved_value "intstr2.ihex" "reload struct as memory, intel hex" \
-	$struct_val "intstruct"
+	$struct_val "\*$struct_ptr_type"
 }
 
 # tekhex format can not be loaded for 64-bit-only platforms
 if ![string compare $is64bitonly "no"] then {
   test_reload_saved_value "intarr1.tekhex" "reload array as value, tekhex" \
-	$array_val "intarray"
+	$array_val "\*$array_ptr_type"
   test_reload_saved_value "intstr1.tekhex" "reload struct as value, tekhex" \
-	$struct_val "intstruct"
+	$struct_val "\*$struct_ptr_type"
   test_reload_saved_value "intarr2.tekhex" "reload array as memory, tekhex" \
-	$array_val "intarray"
+	$array_val "\*$array_ptr_type"
   test_reload_saved_value "intstr2.tekhex" "reload struct as memory, tekhex" \
-	$struct_val "intstruct"
+	$struct_val "\*$struct_ptr_type"
 }
 
 # Start a fresh gdb session
-- 
1.7.0.4

[patch 2/2] Fixes to gdb.base/dump.exp: Combine dump and restore in a single session

[Yao Qi]

[-- Attachment #1: Type: text/plain, Size: 602 bytes --]

On 06/21/2011 06:42 PM, Yao Qi wrote:
> 
>   - 1 Start gdb, and run to checkpoint1.  Dump memory into files of
> different formats.
>   - 3 Start gdb, and restore these dump files.  Compare results in dump
> files are the same them in memory.
> 

In short, this patch is to combine session 1 and session 3 into one
single session, so that symbol address is unchanged.  In this new
session, firstly, we dump memory contents to different formats of files,
clear content in struct and array, and then, restore memory contents
from dumped files one by one, and compare the results.

-- 
Yao (齐尧)

[-- Attachment #2: 0016-fix-test_restore_saved_value.patch --]
[-- Type: text/x-patch, Size: 7688 bytes --]

2011-06-21  Yao Qi  <yao@codesourcery.com>

	gdb/testsuite/
	* gdb.base/dump.exp: Start GDB once, and do `dump' and `restore'
	tests together.

---
 gdb/testsuite/gdb.base/dump.exp |  186 +++++++++++++++++----------------------
 1 files changed, 81 insertions(+), 105 deletions(-)

diff --git a/gdb/testsuite/gdb.base/dump.exp b/gdb/testsuite/gdb.base/dump.exp
index 7042abc..ef34957 100644
--- a/gdb/testsuite/gdb.base/dump.exp
+++ b/gdb/testsuite/gdb.base/dump.exp
@@ -217,49 +217,6 @@ make_dump_file \
 	"dump srec mem intarr3.srec &intarray \(char *\) &intarray + sizeof intarray" \
 	"dump array as mem, srec, expressions"
 
-
-# Now start a fresh gdb session, and reload the saved value files.
-
-gdb_exit
-gdb_start
-gdb_file_cmd ${binfile}
-
-# Now fix the endianness at the correct state.
-
-gdb_test_multiple "set endian $endian" "set endianness" {
-    -re ".* (big|little) endian.*$gdb_prompt $" { 
-	pass "setting $endian endianness"
-    }
-}
-
-# Reload saved values one by one, and compare.
-
-if { ![string compare $array_val \
-	   [capture_value "intarray" "file binfile"]] } then {
-    fail "start with intarray un-initialized"
-} else {
-    pass "start with intarray un-initialized"
-}
-
-if { ![string compare $struct_val \
-	   [capture_value "intstruct" "file binfile"]] } then {
-    fail "start with intstruct un-initialized"
-} else {
-    pass "start with intstruct un-initialized"
-}
-
-proc test_reload_saved_value { filename msg oldval newval } {
-    global gdb_prompt
-    
-    gdb_file_cmd $filename
-    if { ![string compare $oldval \
-	       [capture_value $newval "$msg"]] } then { 
-	pass "$msg; value restored ok"
-    } else {
-	fail "$msg; value restored ok"
-    }
-}
-
 proc test_restore_saved_value { restore_args msg oldval newval } {
     global gdb_prompt
     
@@ -274,71 +231,10 @@ proc test_restore_saved_value { restore_args msg oldval newval } {
     }
 }
 
-# srec format can not be loaded for 64-bit-only platforms
 if ![string compare $is64bitonly "no"] then {
-  test_reload_saved_value "intarr1.srec" "reload array as value, srec" \
-	$array_val "\*$array_ptr_type"
-  test_reload_saved_value "intstr1.srec" "reload struct as value, srec" \
-	$struct_val "\*$struct_ptr_type"
-  test_reload_saved_value "intarr2.srec" "reload array as memory, srec" \
-	$array_val "\*$array_ptr_type"
-  test_reload_saved_value "intstr2.srec" "reload struct as memory, srec" \
-	$struct_val "\*$struct_ptr_type"
-}
-
-# ihex format can not be loaded for 64-bit-only platforms
-if ![string compare $is64bitonly "no"] then {
-
-  test_reload_saved_value "intarr1.ihex" "reload array as value, intel hex" \
-	$array_val "\*$array_ptr_type"
-  test_reload_saved_value "intstr1.ihex" "reload struct as value, intel hex" \
-	$struct_val "\*$struct_ptr_type"
-  test_reload_saved_value "intarr2.ihex" "reload array as memory, intel hex" \
-	$array_val "\*$array_ptr_type"
-  test_reload_saved_value "intstr2.ihex" "reload struct as memory, intel hex" \
-	$struct_val "\*$struct_ptr_type"
-}
-
-# tekhex format can not be loaded for 64-bit-only platforms
-if ![string compare $is64bitonly "no"] then {
-  test_reload_saved_value "intarr1.tekhex" "reload array as value, tekhex" \
-	$array_val "\*$array_ptr_type"
-  test_reload_saved_value "intstr1.tekhex" "reload struct as value, tekhex" \
-	$struct_val "\*$struct_ptr_type"
-  test_reload_saved_value "intarr2.tekhex" "reload array as memory, tekhex" \
-	$array_val "\*$array_ptr_type"
-  test_reload_saved_value "intstr2.tekhex" "reload struct as memory, tekhex" \
-	$struct_val "\*$struct_ptr_type"
-}
 
-# Start a fresh gdb session
-
-gdb_exit
-gdb_start
-gdb_reinitialize_dir $srcdir/$subdir
-gdb_load ${binfile}
-
-# Run to main.
-if { ! [ runto_main ] } then {
-    untested dump.exp
-    return -1
-}
-
-if { ![string compare $array_val \
-	   [capture_value "intarray" "load binfile"]] } then {
-    fail "start with intarray un-initialized, runto main"
-} else {
-    pass "start with intarray un-initialized, runto main"
-}
-
-if { ![string compare $struct_val \
-	   [capture_value "intstruct" "load binfile"]] } then {
-    fail "start with intstruct un-initialized, runto main"
-} else {
-    pass "start with intstruct un-initialized, runto main"
-}
+  gdb_test "print zero_all ()" ".*"
 
-if ![string compare $is64bitonly "no"] then {
   test_restore_saved_value "intarr1.srec" "array as value, srec" \
 	$array_val "intarray"
 
@@ -521,6 +417,86 @@ if ![string compare $is64bitonly "no"] then {
   gdb_test "print intarray2\[4\] == 0" " = 1" "element 4 not changed, == 4"
 }
 
+
+# Now start a fresh gdb session, and reload the saved value files.
+
+gdb_exit
+gdb_start
+gdb_file_cmd ${binfile}
+
+# Now fix the endianness at the correct state.
+
+gdb_test_multiple "set endian $endian" "set endianness" {
+    -re ".* (big|little) endian.*$gdb_prompt $" { 
+	pass "setting $endian endianness"
+    }
+}
+
+# Reload saved values one by one, and compare.
+
+if { ![string compare $array_val \
+	   [capture_value "intarray" "file binfile"]] } then {
+    fail "start with intarray un-initialized"
+} else {
+    pass "start with intarray un-initialized"
+}
+
+if { ![string compare $struct_val \
+	   [capture_value "intstruct" "file binfile"]] } then {
+    fail "start with intstruct un-initialized"
+} else {
+    pass "start with intstruct un-initialized"
+}
+
+proc test_reload_saved_value { filename msg oldval newval } {
+    global gdb_prompt
+    
+    gdb_file_cmd $filename
+    if { ![string compare $oldval \
+	       [capture_value $newval "$msg"]] } then { 
+	pass "$msg; value restored ok"
+    } else {
+	fail "$msg; value restored ok"
+    }
+}
+
+# srec format can not be loaded for 64-bit-only platforms
+if ![string compare $is64bitonly "no"] then {
+  test_reload_saved_value "intarr1.srec" "reload array as value, srec" \
+	$array_val "\*$array_ptr_type"
+  test_reload_saved_value "intstr1.srec" "reload struct as value, srec" \
+	$struct_val "\*$struct_ptr_type"
+  test_reload_saved_value "intarr2.srec" "reload array as memory, srec" \
+	$array_val "\*$array_ptr_type"
+  test_reload_saved_value "intstr2.srec" "reload struct as memory, srec" \
+	$struct_val "\*$struct_ptr_type"
+}
+
+# ihex format can not be loaded for 64-bit-only platforms
+if ![string compare $is64bitonly "no"] then {
+
+  test_reload_saved_value "intarr1.ihex" "reload array as value, intel hex" \
+	$array_val "\*$array_ptr_type"
+  test_reload_saved_value "intstr1.ihex" "reload struct as value, intel hex" \
+	$struct_val "\*$struct_ptr_type"
+  test_reload_saved_value "intarr2.ihex" "reload array as memory, intel hex" \
+	$array_val "\*$array_ptr_type"
+  test_reload_saved_value "intstr2.ihex" "reload struct as memory, intel hex" \
+	$struct_val "\*$struct_ptr_type"
+}
+
+# tekhex format can not be loaded for 64-bit-only platforms
+if ![string compare $is64bitonly "no"] then {
+  test_reload_saved_value "intarr1.tekhex" "reload array as value, tekhex" \
+	$array_val "\*$array_ptr_type"
+  test_reload_saved_value "intstr1.tekhex" "reload struct as value, tekhex" \
+	$struct_val "\*$struct_ptr_type"
+  test_reload_saved_value "intarr2.tekhex" "reload array as memory, tekhex" \
+	$array_val "\*$array_ptr_type"
+  test_reload_saved_value "intstr2.tekhex" "reload struct as memory, tekhex" \
+	$struct_val "\*$struct_ptr_type"
+}
+
 # clean up files
 
 remote_exec build "rm -f intarr1.bin intarr1b.bin intarr1.ihex intarr1.srec intarr1.tekhex intarr2.bin intarr2b.bin intarr2.ihex intarr2.srec intarr2.tekhex intstr1.bin intstr1b.bin intstr1.ihex intstr1.srec intstr1.tekhex intstr2.bin intstr2b.bin intstr2.ihex intstr2.srec intstr2.tekhex intarr3.srec"
-- 
1.7.0.4

Re: [patch 1/2] Fixes to gdb.base/dump.exp: get value from address instead of name

[Tom Tromey]

>>>>> "Yao" == Yao Qi <yao@codesourcery.com> writes:

Yao> IMO, the intention of tests in this gdb session is to test that "gdb is
Yao> able to load these dump files, and read the correct memory contents from
Yao> them", so it doesn't matter too much that gdb get them via name or
Yao> address.  I think the semantics of this part of tests is not changed.

I agree.

Yao> +proc capture_value_with_type { expression } {

I don't fully understand this proc.  Some comments would help.

Yao> +	    if [regexp { \(.*\).*[0-9]+} $expect_out(0,string) output_string] {

Is [0-9]+ really correct?
I would have thought the results would be in hex.
This would be a good spot for a comment describing the expected output.

Yao> +		pass "$test $output_string"
Yao> +	    } else {
Yao> +		fail "$test unable to match regexp"
Yao> +	    }

Passes and fails should use the same text.

Tom

Re: [patch 1/2] Fixes to gdb.base/dump.exp: get value from address instead of name

[Yao Qi]

[-- Attachment #1: Type: text/plain, Size: 800 bytes --]

On 06/22/2011 11:44 PM, Tom Tromey wrote:
>>>>>> "Yao" == Yao Qi <yao@codesourcery.com> writes:

> 
> Yao> +proc capture_value_with_type { expression } {
> 
> I don't fully understand this proc.  Some comments would help.
> 

Sorry about that.  Some comments are added in new patch.

> Yao> +	    if [regexp { \(.*\).*[0-9]+} $expect_out(0,string) output_string] {
> 
> Is [0-9]+ really correct?
> I would have thought the results would be in hex.

Oh, you are right.  Fixed.

> This would be a good spot for a comment describing the expected output.
> 

Comment is added.

> Yao> +		pass "$test $output_string"
> Yao> +	    } else {
> Yao> +		fail "$test unable to match regexp"
> Yao> +	    }
> 
> Passes and fails should use the same text.

Fixed.

patch 2/2 is unchanged.

-- 
Yao (齐尧)

[-- Attachment #2: 0017-fix-for-test_reload_saved_value.patch --]
[-- Type: text/x-patch, Size: 4109 bytes --]

	gdb/testsuite/
	* gdb.base/dump.exp (capture_pointer_with_type): New.
	Get value from address instead of name.

---
 gdb/testsuite/gdb.base/dump.exp |   55 ++++++++++++++++++++++++++++++--------
 1 files changed, 43 insertions(+), 12 deletions(-)

diff --git a/gdb/testsuite/gdb.base/dump.exp b/gdb/testsuite/gdb.base/dump.exp
index 1f307f4..15bb249 100644
--- a/gdb/testsuite/gdb.base/dump.exp
+++ b/gdb/testsuite/gdb.base/dump.exp
@@ -152,6 +152,34 @@ proc capture_value { expression args } {
     return $output_string
 }
 
+# POINTER is a pointer and this proc captures the value of POINTER along
+# with POINTER's type.  For example, POINTER is "&intarray", this proc will
+# call "p &intarray", capture "(int (*)[32]) 0x804a0e0", and return this
+# string.
+
+proc capture_pointer_with_type { pointer } {
+    global gdb_prompt
+    global expect_out
+
+    set test "capture type of pointer $pointer"
+    set output_string ""
+    gdb_test_multiple "p ${pointer}" $test {
+	-re "\\$\[0-9\]+ = .*$gdb_prompt $" {
+	    # Expected output of "p ${pointer}" is like "$7 = (int (*)[32]) 0x804a0e0",
+	    # and we want to extract "(int (*)[32]) 0x804a0e0" from it via
+	    # following regexp.
+	    if [regexp { \(.*\).*[a-fA-F0-9]+} $expect_out(0,string) output_string] {
+		# OUTPUT_STRING is expected to be like "(int (*)[32]) 0x804a0e0".
+		pass "$test"
+	    } else {
+		fail "$test"
+	    }
+	}
+    }
+
+    return $output_string
+}
+
 set array_start  [capture_value "/x &intarray\[0\]"]
 set array_end    [capture_value "/x &intarray\[32\]"]
 set struct_start [capture_value "/x &intstruct"]
@@ -160,6 +188,9 @@ set struct_end   [capture_value "/x &intstruct + 1"]
 set array_val    [capture_value "intarray"]
 set struct_val   [capture_value "intstruct"]
 
+set array_ptr_type [capture_pointer_with_type "&intarray"]
+set struct_ptr_type [capture_pointer_with_type "&intstruct"]
+
 make_dump_file "dump mem intarr2.bin $array_start $array_end" \
 	"dump array as memory, default"
 
@@ -255,38 +286,38 @@ proc test_restore_saved_value { restore_args msg oldval newval } {
 # srec format can not be loaded for 64-bit-only platforms
 if ![string compare $is64bitonly "no"] then {
   test_reload_saved_value "intarr1.srec" "reload array as value, srec" \
-	$array_val "intarray"
+	$array_val "\*$array_ptr_type"
   test_reload_saved_value "intstr1.srec" "reload struct as value, srec" \
-	$struct_val "intstruct"
+	$struct_val "\*$struct_ptr_type"
   test_reload_saved_value "intarr2.srec" "reload array as memory, srec" \
-	$array_val "intarray"
+	$array_val "\*$array_ptr_type"
   test_reload_saved_value "intstr2.srec" "reload struct as memory, srec" \
-	$struct_val "intstruct"
+	$struct_val "\*$struct_ptr_type"
 }
 
 # ihex format can not be loaded for 64-bit-only platforms
 if ![string compare $is64bitonly "no"] then {
 
   test_reload_saved_value "intarr1.ihex" "reload array as value, intel hex" \
-	$array_val "intarray"
+	$array_val "\*$array_ptr_type"
   test_reload_saved_value "intstr1.ihex" "reload struct as value, intel hex" \
-	$struct_val "intstruct"
+	$struct_val "\*$struct_ptr_type"
   test_reload_saved_value "intarr2.ihex" "reload array as memory, intel hex" \
-	$array_val "intarray"
+	$array_val "\*$array_ptr_type"
   test_reload_saved_value "intstr2.ihex" "reload struct as memory, intel hex" \
-	$struct_val "intstruct"
+	$struct_val "\*$struct_ptr_type"
 }
 
 # tekhex format can not be loaded for 64-bit-only platforms
 if ![string compare $is64bitonly "no"] then {
   test_reload_saved_value "intarr1.tekhex" "reload array as value, tekhex" \
-	$array_val "intarray"
+	$array_val "\*$array_ptr_type"
   test_reload_saved_value "intstr1.tekhex" "reload struct as value, tekhex" \
-	$struct_val "intstruct"
+	$struct_val "\*$struct_ptr_type"
   test_reload_saved_value "intarr2.tekhex" "reload array as memory, tekhex" \
-	$array_val "intarray"
+	$array_val "\*$array_ptr_type"
   test_reload_saved_value "intstr2.tekhex" "reload struct as memory, tekhex" \
-	$struct_val "intstruct"
+	$struct_val "\*$struct_ptr_type"
 }
 
 # Start a fresh gdb session
-- 
1.7.0.4

Re: [patch 1/2] Fixes to gdb.base/dump.exp: get value from address instead of name

[Yao Qi]

On 06/23/2011 06:27 PM, Yao Qi wrote:
> 	gdb/testsuite/
> 	* gdb.base/dump.exp (capture_pointer_with_type): New.
> 	Get value from address instead of name.

Ping?

[patch 1/2] Fixes to gdb.base/dump.exp: get value from address instead
of name
http://sourceware.org/ml/gdb-patches/2011-06/msg00341.html

[patch 2/2] Fixes to gdb.base/dump.exp: Combine dump and restore in a
single session
http://sourceware.org/ml/gdb-patches/2011-06/msg00281.html

-- 
Yao (齐尧)

Re: [patch 1/2] Fixes to gdb.base/dump.exp: get value from address instead of name

[Tom Tromey]

>>>>> "Yao" == Yao Qi <yao@codesourcery.com> writes:

Yao> Ping?

Thanks for the reminder.

Yao> [patch 1/2] Fixes to gdb.base/dump.exp: get value from address instead
Yao> of name
Yao> http://sourceware.org/ml/gdb-patches/2011-06/msg00341.html

Yao> [patch 2/2] Fixes to gdb.base/dump.exp: Combine dump and restore in a
Yao> single session
Yao> http://sourceware.org/ml/gdb-patches/2011-06/msg00281.html

These are both OK.
Thanks.

Tom

[committed] [patch 1/2] Fixes to gdb.base/dump.exp: get value from address instead of name

[Yao Qi]

On 07/01/2011 10:22 PM, Tom Tromey wrote:
>>>>>> "Yao" == Yao Qi <yao@codesourcery.com> writes:
> 
> Yao> Ping?
> 
> Thanks for the reminder.
> 
> Yao> [patch 1/2] Fixes to gdb.base/dump.exp: get value from address instead
> Yao> of name
> Yao> http://sourceware.org/ml/gdb-patches/2011-06/msg00341.html
> 
> Yao> [patch 2/2] Fixes to gdb.base/dump.exp: Combine dump and restore in a
> Yao> single session
> Yao> http://sourceware.org/ml/gdb-patches/2011-06/msg00281.html
> 
> These are both OK.
> Thanks.

Thanks for the review.  Committed.
http://sourceware.org/ml/gdb-cvs/2011-07/msg00005.html

-- 
Yao (齐尧)