On 06/22/2011 11:44 PM, Tom Tromey wrote:
>>>>>> "Yao" == Yao Qi <yao@codesourcery.com> writes:

> 
> Yao> +proc capture_value_with_type { expression } {
> 
> I don't fully understand this proc.  Some comments would help.
> 

Sorry about that.  Some comments are added in new patch.

> Yao> +	    if [regexp { \(.*\).*[0-9]+} $expect_out(0,string) output_string] {
> 
> Is [0-9]+ really correct?
> I would have thought the results would be in hex.

Oh, you are right.  Fixed.

> This would be a good spot for a comment describing the expected output.
> 

Comment is added.

> Yao> +		pass "$test $output_string"
> Yao> +	    } else {
> Yao> +		fail "$test unable to match regexp"
> Yao> +	    }
> 
> Passes and fails should use the same text.

Fixed.

patch 2/2 is unchanged.

-- 
Yao (齐尧)