* [RFA] bfd/dwarf2.c/scan_unit_for_symbols, fix a memory leak.
@ 2011-03-03 20:13 Michael Snyder
2011-03-03 22:12 ` Alan Modra
0 siblings, 1 reply; 3+ messages in thread
From: Michael Snyder @ 2011-03-03 20:13 UTC (permalink / raw)
To: nickc, amodra, bug-binutils, gdb-patches
[-- Attachment #1: Type: text/plain, Size: 5 bytes --]
ok?
[-- Attachment #2: dwarf2.txt --]
[-- Type: text/plain, Size: 601 bytes --]
2011-03-03 Michael Snyder <msnyder@vmware.com>
* dwarf2.c (scan_unit_for_symbols): Stop memory leak.
Index: dwarf2.c
===================================================================
RCS file: /cvs/src/src/bfd/dwarf2.c,v
retrieving revision 1.138
diff -u -p -u -p -r1.138 dwarf2.c
--- dwarf2.c 29 Oct 2010 12:10:23 -0000 1.138
+++ dwarf2.c 3 Mar 2011 20:09:27 -0000
@@ -2148,7 +2148,7 @@ scan_unit_for_symbols (struct comp_unit
{
info_ptr = read_attribute (&attr, &abbrev->attrs[i], unit, info_ptr);
if (info_ptr == NULL)
- return FALSE;
+ goto fail;
if (func)
{
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [RFA] bfd/dwarf2.c/scan_unit_for_symbols, fix a memory leak.
2011-03-03 20:13 [RFA] bfd/dwarf2.c/scan_unit_for_symbols, fix a memory leak Michael Snyder
@ 2011-03-03 22:12 ` Alan Modra
2011-03-03 23:43 ` Michael Snyder
0 siblings, 1 reply; 3+ messages in thread
From: Alan Modra @ 2011-03-03 22:12 UTC (permalink / raw)
To: Michael Snyder; +Cc: nickc, bug-binutils, gdb-patches
On Thu, Mar 03, 2011 at 12:12:52PM -0800, Michael Snyder wrote:
> 2011-03-03 Michael Snyder <msnyder@vmware.com>
>
> * dwarf2.c (scan_unit_for_symbols): Stop memory leak.
OK.
--
Alan Modra
Australia Development Lab, IBM
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [RFA] bfd/dwarf2.c/scan_unit_for_symbols, fix a memory leak.
2011-03-03 22:12 ` Alan Modra
@ 2011-03-03 23:43 ` Michael Snyder
0 siblings, 0 replies; 3+ messages in thread
From: Michael Snyder @ 2011-03-03 23:43 UTC (permalink / raw)
To: Michael Snyder, nickc, bug-binutils, gdb-patches
Alan Modra wrote:
> On Thu, Mar 03, 2011 at 12:12:52PM -0800, Michael Snyder wrote:
>> 2011-03-03 Michael Snyder <msnyder@vmware.com>
>>
>> * dwarf2.c (scan_unit_for_symbols): Stop memory leak.
>
> OK.
>
Thanks for the review.
Committed.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2011-03-03 23:43 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2011-03-03 20:13 [RFA] bfd/dwarf2.c/scan_unit_for_symbols, fix a memory leak Michael Snyder
2011-03-03 22:12 ` Alan Modra
2011-03-03 23:43 ` Michael Snyder
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox