Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Michael Snyder <msnyder@vmware.com>
To: "nickc@redhat.com" <nickc@redhat.com>,
	amodra@gmail.com,  "bug-binutils@gnu.org" <bug-binutils@gnu.org>,
	"gdb-patches@sourceware.org" <gdb-patches@sourceware.org>
Subject: [RFA] bfd/dwarf2.c/scan_unit_for_symbols, fix a memory leak.
Date: Thu, 03 Mar 2011 20:13:00 -0000	[thread overview]
Message-ID: <4D6FF644.7090903@vmware.com> (raw)

[-- Attachment #1: Type: text/plain, Size: 5 bytes --]

ok?


[-- Attachment #2: dwarf2.txt --]
[-- Type: text/plain, Size: 601 bytes --]

2011-03-03  Michael Snyder  <msnyder@vmware.com>

	* dwarf2.c (scan_unit_for_symbols): Stop memory leak.

Index: dwarf2.c
===================================================================
RCS file: /cvs/src/src/bfd/dwarf2.c,v
retrieving revision 1.138
diff -u -p -u -p -r1.138 dwarf2.c
--- dwarf2.c	29 Oct 2010 12:10:23 -0000	1.138
+++ dwarf2.c	3 Mar 2011 20:09:27 -0000
@@ -2148,7 +2148,7 @@ scan_unit_for_symbols (struct comp_unit 
 	{
 	  info_ptr = read_attribute (&attr, &abbrev->attrs[i], unit, info_ptr);
 	  if (info_ptr == NULL)
-	    return FALSE;
+	    goto fail;
 
 	  if (func)
 	    {

             reply	other threads:[~2011-03-03 20:13 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-03-03 20:13 Michael Snyder [this message]
2011-03-03 22:12 ` Alan Modra
2011-03-03 23:43   ` Michael Snyder

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4D6FF644.7090903@vmware.com \
    --to=msnyder@vmware.com \
    --cc=amodra@gmail.com \
    --cc=bug-binutils@gnu.org \
    --cc=gdb-patches@sourceware.org \
    --cc=nickc@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox