From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 24837 invoked by alias); 3 Mar 2011 20:13:01 -0000 Received: (qmail 24805 invoked by uid 22791); 3 Mar 2011 20:12:57 -0000 X-SWARE-Spam-Status: No, hits=-2.4 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,SHORT_BODY,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from smtp-outbound-2.vmware.com (HELO smtp-outbound-2.vmware.com) (65.115.85.73) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 03 Mar 2011 20:12:53 +0000 Received: from mailhost3.vmware.com (mailhost3.vmware.com [10.16.27.45]) by smtp-outbound-2.vmware.com (Postfix) with ESMTP id 7D0A940007; Thu, 3 Mar 2011 12:12:52 -0800 (PST) Received: from msnyder-server.eng.vmware.com (promd-2s-dhcp138.eng.vmware.com [10.20.124.138]) by mailhost3.vmware.com (Postfix) with ESMTP id 6D728CD9C6; Thu, 3 Mar 2011 12:12:52 -0800 (PST) Message-ID: <4D6FF644.7090903@vmware.com> Date: Thu, 03 Mar 2011 20:13:00 -0000 From: Michael Snyder User-Agent: Thunderbird 2.0.0.24 (X11/20101201) MIME-Version: 1.0 To: "nickc@redhat.com" , amodra@gmail.com, "bug-binutils@gnu.org" , "gdb-patches@sourceware.org" Subject: [RFA] bfd/dwarf2.c/scan_unit_for_symbols, fix a memory leak. Content-Type: multipart/mixed; boundary="------------040009060008020104030605" X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2011-03/txt/msg00206.txt.bz2 This is a multi-part message in MIME format. --------------040009060008020104030605 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Content-length: 5 ok? --------------040009060008020104030605 Content-Type: text/plain; name="dwarf2.txt" Content-Transfer-Encoding: 7bit Content-Disposition: inline; filename="dwarf2.txt" Content-length: 601 2011-03-03 Michael Snyder * dwarf2.c (scan_unit_for_symbols): Stop memory leak. Index: dwarf2.c =================================================================== RCS file: /cvs/src/src/bfd/dwarf2.c,v retrieving revision 1.138 diff -u -p -u -p -r1.138 dwarf2.c --- dwarf2.c 29 Oct 2010 12:10:23 -0000 1.138 +++ dwarf2.c 3 Mar 2011 20:09:27 -0000 @@ -2148,7 +2148,7 @@ scan_unit_for_symbols (struct comp_unit { info_ptr = read_attribute (&attr, &abbrev->attrs[i], unit, info_ptr); if (info_ptr == NULL) - return FALSE; + goto fail; if (func) { --------------040009060008020104030605--