[commit] fork-child.c, fork_inferior: Delete ifdef'd code and unused variable.

[commit] fork-child.c, fork_inferior: Delete ifdef'd code and unused variable.

[Michael Snyder]

[-- Attachment #1: Type: text/plain, Size: 13 bytes --]

checked in.


[-- Attachment #2: unused14.txt --]
[-- Type: text/plain, Size: 1112 bytes --]

2011-02-28  Michael Snyder  <msnyder@vmware.com>

	* fork-child.c (fork_inferior): Remove ifdef'd code and
	unused variable.

Index: fork-child.c
===================================================================
RCS file: /cvs/src/src/gdb/fork-child.c,v
retrieving revision 1.61
diff -u -p -u -p -r1.61 fork-child.c
--- fork-child.c	11 Jan 2011 15:10:01 -0000	1.61
+++ fork-child.c	1 Mar 2011 00:50:41 -0000
@@ -367,12 +367,11 @@ fork_inferior (char *exec_file_arg, char
 	  /* Otherwise, we directly exec the target program with
 	     execvp.  */
 	  int i;
-	  char *errstring;
 
 	  execvp (exec_file, argv);
 
 	  /* If we get here, it's an error.  */
-	  errstring = safe_strerror (errno);
+	  safe_strerror (errno);
 	  fprintf_unfiltered (gdb_stderr, "Cannot exec %s ", exec_file);
 
 	  i = 1;
@@ -384,10 +383,6 @@ fork_inferior (char *exec_file_arg, char
 	      i++;
 	    }
 	  fprintf_unfiltered (gdb_stderr, ".\n");
-#if 0
-	  /* This extra info seems to be useless.  */
-	  fprintf_unfiltered (gdb_stderr, "Got error %s.\n", errstring);
-#endif
 	  gdb_flush (gdb_stderr);
 	  _exit (0177);
 	}

Re: [commit] fork-child.c, fork_inferior: Delete ifdef'd code and unused variable.

[Mark Kettenis]

> Date: Mon, 28 Feb 2011 16:53:19 -0800
> From: Michael Snyder <msnyder@vmware.com>
> 
> checked in.
> 
> 2011-02-28  Michael Snyder  <msnyder@vmware.com>
> 
> 	* fork-child.c (fork_inferior): Remove ifdef'd code and
> 	unused variable.
> 
> Index: fork-child.c
> ===================================================================
> RCS file: /cvs/src/src/gdb/fork-child.c,v
> retrieving revision 1.61
> diff -u -p -u -p -r1.61 fork-child.c
> --- fork-child.c	11 Jan 2011 15:10:01 -0000	1.61
> +++ fork-child.c	1 Mar 2011 00:50:41 -0000
> @@ -367,12 +367,11 @@ fork_inferior (char *exec_file_arg, char
>  	  /* Otherwise, we directly exec the target program with
>  	     execvp.  */
>  	  int i;
> -	  char *errstring;
>  
>  	  execvp (exec_file, argv);
>  
>  	  /* If we get here, it's an error.  */
> -	  errstring = safe_strerror (errno);
> +	  safe_strerror (errno);

Wait a moment!  That safe_strerror() call is pretty much a no-op now.
I'm sure whoever wrote that code intended to actually display the
error string.

Re: [commit] fork-child.c, fork_inferior: Delete ifdef'd code and unused variable.

[Michael Snyder]

Mark Kettenis wrote:
>> Date: Mon, 28 Feb 2011 16:53:19 -0800
>> From: Michael Snyder <msnyder@vmware.com>
>>
>> checked in.
>>
>> 2011-02-28  Michael Snyder  <msnyder@vmware.com>
>>
>> 	* fork-child.c (fork_inferior): Remove ifdef'd code and
>> 	unused variable.
>>
>> Index: fork-child.c
>> ===================================================================
>> RCS file: /cvs/src/src/gdb/fork-child.c,v
>> retrieving revision 1.61
>> diff -u -p -u -p -r1.61 fork-child.c
>> --- fork-child.c	11 Jan 2011 15:10:01 -0000	1.61
>> +++ fork-child.c	1 Mar 2011 00:50:41 -0000
>> @@ -367,12 +367,11 @@ fork_inferior (char *exec_file_arg, char
>>  	  /* Otherwise, we directly exec the target program with
>>  	     execvp.  */
>>  	  int i;
>> -	  char *errstring;
>>  
>>  	  execvp (exec_file, argv);
>>  
>>  	  /* If we get here, it's an error.  */
>> -	  errstring = safe_strerror (errno);
>> +	  safe_strerror (errno);
> 
> Wait a moment!  That safe_strerror() call is pretty much a no-op now.

Arg, I should have removed it -- auto pilot.

> I'm sure whoever wrote that code intended to actually display the
> error string.

OK -- but you were the one who commented out the actual display.
Whatever you want to do, I am ok with...

1.23         (kettenis 30-Sep-04): #if 0
1.23         (kettenis 30-Sep-04):        /* This extra info seems to be 
useles\
s.  */
1.23         (kettenis 30-Sep-04):        fprintf_unfiltered 
(gdb_stderr, "Got \
error %s.\n", errstring);
1.23         (kettenis 30-Sep-04): #endif
1