From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-78910-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 17827 invoked by alias); 1 Mar 2011 08:49:12 -0000
Received: (qmail 17817 invoked by uid 22791); 1 Mar 2011 08:49:11 -0000
X-SWARE-Spam-Status: No, hits=-2.0 required=5.0	tests=AWL,BAYES_00,T_RP_MATCHES_RCVD
X-Spam-Check-By: sourceware.org
Received: from sibelius.xs4all.nl (HELO glazunov.sibelius.xs4all.nl) (83.163.83.176)    by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 01 Mar 2011 08:49:06 +0000
Received: from glazunov.sibelius.xs4all.nl (kettenis@localhost [127.0.0.1])	by glazunov.sibelius.xs4all.nl (8.14.3/8.14.3) with ESMTP id p218n22U017488;	Tue, 1 Mar 2011 09:49:02 +0100 (CET)
Received: (from kettenis@localhost)	by glazunov.sibelius.xs4all.nl (8.14.3/8.14.3/Submit) id p218n0je030214;	Tue, 1 Mar 2011 09:49:00 +0100 (CET)
Date: Tue, 01 Mar 2011 08:49:00 -0000
Message-Id: <201103010849.p218n0je030214@glazunov.sibelius.xs4all.nl>
From: Mark Kettenis <mark.kettenis@xs4all.nl>
To: msnyder@vmware.com
CC: gdb-patches@sourceware.org
In-reply-to: <4D6C437F.3030700@vmware.com> (message from Michael Snyder on	Mon, 28 Feb 2011 16:53:19 -0800)
Subject: Re: [commit] fork-child.c, fork_inferior: Delete ifdef'd code and unused variable.
References:  <4D6C437F.3030700@vmware.com>
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2011-03/txt/msg00023.txt.bz2

> Date: Mon, 28 Feb 2011 16:53:19 -0800
> From: Michael Snyder <msnyder@vmware.com>
> 
> checked in.
> 
> 2011-02-28  Michael Snyder  <msnyder@vmware.com>
> 
> 	* fork-child.c (fork_inferior): Remove ifdef'd code and
> 	unused variable.
> 
> Index: fork-child.c
> ===================================================================
> RCS file: /cvs/src/src/gdb/fork-child.c,v
> retrieving revision 1.61
> diff -u -p -u -p -r1.61 fork-child.c
> --- fork-child.c	11 Jan 2011 15:10:01 -0000	1.61
> +++ fork-child.c	1 Mar 2011 00:50:41 -0000
> @@ -367,12 +367,11 @@ fork_inferior (char *exec_file_arg, char
>  	  /* Otherwise, we directly exec the target program with
>  	     execvp.  */
>  	  int i;
> -	  char *errstring;
>  
>  	  execvp (exec_file, argv);
>  
>  	  /* If we get here, it's an error.  */
> -	  errstring = safe_strerror (errno);
> +	  safe_strerror (errno);

Wait a moment!  That safe_strerror() call is pretty much a no-op now.
I'm sure whoever wrote that code intended to actually display the
error string.