From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 7792 invoked by alias); 1 Mar 2011 18:57:13 -0000 Received: (qmail 7782 invoked by uid 22791); 1 Mar 2011 18:57:12 -0000 X-SWARE-Spam-Status: No, hits=-5.0 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from smtp-outbound-2.vmware.com (HELO smtp-outbound-2.vmware.com) (65.115.85.73) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 01 Mar 2011 18:57:04 +0000 Received: from mailhost2.vmware.com (mailhost2.vmware.com [10.16.67.167]) by smtp-outbound-2.vmware.com (Postfix) with ESMTP id A5B15390C3; Tue, 1 Mar 2011 10:57:03 -0800 (PST) Received: from msnyder-server.eng.vmware.com (promd-2s-dhcp138.eng.vmware.com [10.20.124.138]) by mailhost2.vmware.com (Postfix) with ESMTP id 9F5AE8EE15; Tue, 1 Mar 2011 10:57:03 -0800 (PST) Message-ID: <4D6D417F.3070301@vmware.com> Date: Tue, 01 Mar 2011 18:57:00 -0000 From: Michael Snyder User-Agent: Thunderbird 2.0.0.24 (X11/20101201) MIME-Version: 1.0 To: Mark Kettenis CC: "gdb-patches@sourceware.org" Subject: Re: [commit] fork-child.c, fork_inferior: Delete ifdef'd code and unused variable. References: <4D6C437F.3030700@vmware.com> <201103010849.p218n0je030214@glazunov.sibelius.xs4all.nl> In-Reply-To: <201103010849.p218n0je030214@glazunov.sibelius.xs4all.nl> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2011-03/txt/msg00037.txt.bz2 Mark Kettenis wrote: >> Date: Mon, 28 Feb 2011 16:53:19 -0800 >> From: Michael Snyder >> >> checked in. >> >> 2011-02-28 Michael Snyder >> >> * fork-child.c (fork_inferior): Remove ifdef'd code and >> unused variable. >> >> Index: fork-child.c >> =================================================================== >> RCS file: /cvs/src/src/gdb/fork-child.c,v >> retrieving revision 1.61 >> diff -u -p -u -p -r1.61 fork-child.c >> --- fork-child.c 11 Jan 2011 15:10:01 -0000 1.61 >> +++ fork-child.c 1 Mar 2011 00:50:41 -0000 >> @@ -367,12 +367,11 @@ fork_inferior (char *exec_file_arg, char >> /* Otherwise, we directly exec the target program with >> execvp. */ >> int i; >> - char *errstring; >> >> execvp (exec_file, argv); >> >> /* If we get here, it's an error. */ >> - errstring = safe_strerror (errno); >> + safe_strerror (errno); > > Wait a moment! That safe_strerror() call is pretty much a no-op now. Arg, I should have removed it -- auto pilot. > I'm sure whoever wrote that code intended to actually display the > error string. OK -- but you were the one who commented out the actual display. Whatever you want to do, I am ok with... 1.23 (kettenis 30-Sep-04): #if 0 1.23 (kettenis 30-Sep-04): /* This extra info seems to be useles\ s. */ 1.23 (kettenis 30-Sep-04): fprintf_unfiltered (gdb_stderr, "Got \ error %s.\n", errstring); 1.23 (kettenis 30-Sep-04): #endif 1