Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Yao Qi <yao@codesourcery.com>
To: Joel Brobecker <brobecker@adacore.com>
Cc: Tom Tromey <tromey@redhat.com>,
	Pedro Alves <pedro@codesourcery.com>,
	 gdb-patches@sourceware.org
Subject: Re: [rfa/rfc] Build libcommon.a for gdb and gdbserver
Date: Tue, 01 Mar 2011 05:46:00 -0000	[thread overview]
Message-ID: <4D6C882B.7010801@codesourcery.com> (raw)
In-Reply-To: <20110301044144.GH30306@adacore.com>

On 03/01/2011 12:41 PM, Joel Brobecker wrote:
>> Yao> Personally, I still prefer a separated configure/makefile in common/,
>> Yao> because,
>> Yao> 1.  if my patch works, configure/make is not a problem,
>> Yao> 2.  if we look forward, there should be quite a few *.c and *.h files in
>> Yao> common in the future.  Write rules in both gdb/Makefile.in and
>> Yao> gdbserver/Makefile.in doesn't scale.
>>
>> I think the most important thing is that if you want to keep the
>> common/configure stuff, then please fix the existing problems that have
>> been reported.  Maybe it is just the GNU make-ism at this point, I
>> haven't kept track.
> 
> On my end of things, I actually do not like the multiple layers of
> miniature configure scripts. These things just keep doing the same
> checks over and over for the most part.  It's particularly visible
> on Windows, were configure takes ages because spawning a script is
> utterly inefficient.  (and as such, Tom's proposal to remove the
> configure script in gdb/testsuite seems like a good idea to me too)
> 
> That being said, as long as it works, it's not of uber importance
> to me but I am not certain that argument number 2 above from Yao
> really is that much work. So, if we fix things fast, I do not mind
> continuing with the present approach. (does anyone know what the
> remaining issues are, though?)
> 

AFAIK, there are three problems,

1. Build failure on mingw32, reported by Pierre. See
<http://sourceware.org/ml/gdb-patches/2011-02/msg00285.html>
I'll give a patch to fix this.

2. make clean doesn't run in gdbserver/common, reported by Michael.
http://sourceware.org/ml/gdb/2011-02/msg00126.html
Patch was sent to the wrong place.  I'll send it again to gdb-patches@.

3.  GNU make feature,
http://sourceware.org/ml/gdb-patches/2011-02/msg00489.html
Since we decide not to require GNU make, I'll remove its GNU make feature.

Am I missing any problems else?

-- 
Yao (齐尧)


  reply	other threads:[~2011-03-01  5:46 UTC|newest]

Thread overview: 94+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-01-15  0:52 Yao Qi
2011-01-15  0:57 ` Pedro Alves
2011-01-17 17:11 ` Tom Tromey
2011-01-17 18:41   ` Joel Brobecker
2011-01-18  0:42   ` Yao Qi
2011-01-18  5:20     ` Pedro Alves
2011-01-18 15:29     ` Tom Tromey
2011-01-19 23:26       ` Yao Qi
2011-01-28 15:04         ` Tom Tromey
2011-01-28 15:22           ` Pedro Alves
2011-01-28 15:52             ` Pedro Alves
2011-02-03 21:30             ` Tom Tromey
2011-02-11  9:58               ` Yao Qi
2011-02-11 18:47                 ` Tom Tromey
2011-02-12  3:13                   ` Yao Qi
2011-02-14 14:50                     ` Tom Tromey
2011-02-14 15:19                     ` Tom Tromey
2011-02-14 17:43                       ` Pierre Muller
2011-02-14 17:58                         ` Pierre Muller
2011-02-14 18:22                       ` Tom Tromey
2011-02-14 19:31                         ` Change gdb/common/ to use Automake [was: Re: [rfa/rfc] Build libcommon.a for gdb and gdbserver] Pedro Alves
2011-02-14 19:39                           ` Change gdb/common/ to use Automake Tom Tromey
2011-02-14 20:13                             ` Pedro Alves
2011-02-14 20:14                               ` Tom Tromey
2011-02-15  6:46                                 ` Joel Brobecker
2011-02-18 23:59                                 ` Doug Evans
2011-02-14 22:11                               ` Tom Tromey
2011-02-14 23:16                                 ` Pedro Alves
2011-02-18 19:54                                 ` Tom Tromey
2011-02-23  7:21                                   ` Yao Qi
2011-02-23 17:24                                     ` Tom Tromey
2011-02-15 13:08                         ` [rfa/rfc] Build libcommon.a for gdb and gdbserver Pierre Muller
2011-02-15 13:20                           ` Pierre Muller
2011-02-18 16:15                             ` Tom Tromey
2011-02-18 16:58                               ` Pierre Muller
2011-02-18 15:53                         ` Tom Tromey
2011-02-23  5:26                         ` Yao Qi
2011-02-23 16:38                           ` Tom Tromey
2011-02-23 17:42                             ` Tom Tromey
2011-02-23 18:05                               ` Joel Brobecker
2011-02-23 18:31                               ` Joel Brobecker
2011-02-23 18:47                               ` Pedro Alves
2011-02-23 20:22                                 ` Tom Tromey
2011-02-23 20:28                                   ` Pedro Alves
2011-02-23 20:36                                     ` Tom Tromey
2011-02-23 20:57                                       ` Pedro Alves
2011-02-24  3:58                             ` Yao Qi
2011-02-28 18:10                               ` Tom Tromey
2011-03-01  4:42                                 ` Joel Brobecker
2011-03-01  5:46                                   ` Yao Qi [this message]
2011-03-01 10:52                                     ` Joel Brobecker
2011-03-01 14:36                                     ` Tom Tromey
2011-03-02  4:41                                       ` Yao Qi
2011-03-02 14:38                                         ` Tom Tromey
2011-03-03  6:00                                           ` Yao Qi
2011-02-15  8:11                       ` Yao Qi
2011-01-31  2:01           ` Yao Qi
2011-02-12 13:06         ` Yao Qi
2011-02-15 13:54         ` Jan Kratochvil
2011-02-15 15:32           ` Yao Qi
2011-02-15 21:07             ` Jan Kratochvil
2011-02-15 21:18           ` [obv] Merge gdb/common/Changelog to gdb/ChangeLog [Re: [rfa/rfc] Build libcommon.a for gdb and gdbserver] Jan Kratochvil
2011-02-16  1:54             ` Yao Qi
2011-02-16  6:55               ` Jan Kratochvil
2011-02-16  8:38               ` Stan Shebs
2011-02-16 18:17                 ` Michael Snyder
2011-02-16 19:40                   ` Tom Tromey
2011-02-16 19:47                     ` Michael Snyder
2011-02-16 19:57                       ` Tom Tromey
2011-02-16 20:18                         ` Michael Snyder
2011-02-17  4:03                         ` Yao Qi
2011-02-16 22:03                   ` Stan Shebs
2011-02-17 19:02                     ` Frank Ch. Eigler
2011-02-16 16:49               ` Tom Tromey
2011-02-18 18:49         ` [rfa/rfc] Build libcommon.a for gdb and gdbserver Tom Tromey
2011-02-19 12:35           ` Joel Brobecker
2011-02-19 13:20             ` Andreas Tobler
2011-02-19 13:50             ` Mark Kettenis
2011-02-19 17:24               ` Joel Brobecker
2011-02-19 18:01                 ` Mark Kettenis
2011-02-21  6:31                   ` Pedro Alves
2011-02-23 21:53                     ` Mark Kettenis
2011-02-23 22:50                       ` Pedro Alves
2011-02-23 23:50                         ` Pedro Alves
2011-03-06 17:23               ` Jan Kratochvil
2011-03-06 18:23                 ` Mark Kettenis
2011-03-06 18:28                   ` Andreas Schwab
2011-03-06 22:44                     ` [patch] Fix Solaris make gdb/data-directory/ compat. [Re: [rfa/rfc] Build libcommon.a for gdb and gdbserver] Jan Kratochvil
2011-03-07  4:28                       ` Yao Qi
2011-03-07  4:35                         ` Jan Kratochvil
2011-03-07 16:50                       ` Tom Tromey
2011-02-21 18:58         ` [patch] Regression on CFLAGS=-m32 build " Jan Kratochvil
2011-02-21 20:09           ` Jan Kratochvil
2011-01-18  0:45   ` [rfa/rfc] Build libcommon.a for gdb and gdbserver Pedro Alves

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4D6C882B.7010801@codesourcery.com \
    --to=yao@codesourcery.com \
    --cc=brobecker@adacore.com \
    --cc=gdb-patches@sourceware.org \
    --cc=pedro@codesourcery.com \
    --cc=tromey@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox