From: Jan Kratochvil <jan.kratochvil@redhat.com>
To: Yao Qi <yao@codesourcery.com>
Cc: Tom Tromey <tromey@redhat.com>, gdb-patches@sourceware.org
Subject: [patch] Regression on CFLAGS=-m32 build [Re: [rfa/rfc] Build libcommon.a for gdb and gdbserver]
Date: Mon, 21 Feb 2011 18:58:00 -0000 [thread overview]
Message-ID: <20110221184444.GA4349@host1.dyn.jankratochvil.net> (raw)
In-Reply-To: <4D375F44.70504@codesourcery.com>
Hi Yao,
wrt
commit 8c5a634bffb212fadf96c090f12551160fffca3f
2011-02-11 Yao Qi <yao@codesourcery.com>
* Makefile.in: Remove signals.o from COMMON_OBS. Link
libcommon.a.
* configure.ac: Add common to sub dir.
* configure: Regenerate.
common/
2011-02-11 Yao Qi <yao@codesourcery.com>
Build libcommon.a.
* Makefile.in: New.
* configure.ac: New.
* aclocal.m4: New.
* configure: Generate.
gdbserver/
2011-02-11 Yao Qi <yao@codesourcery.com>
* configure.ac: Call AC_PROG_RANLIB.
* Makefile.in: Remove signals.o from OBS. Link libcommon.a.
* configure: Regenerate.
there is a regression for common/ as it no longer uses @CFLAGS@ now.
This will crash compilation on x86_64 box using:
CFLAGS=-m32 ./configure i386-unknown-linux-gnu;make
->
common/libcommon.a: could not read symbols: File in wrong format
->
libcommon/signals.o: ELF 64-bit LSB relocatable, x86-64, version 1 (SYSV), not stripped
I put $(CFLAGS) to the end, so that a user can override other options.
Currently in gdb/Makefile.in $(CFLAGS) is at the beginning of the line.
It may all get obsoleted soon by Tom's automake.
I will check it in today with no comments, it seems serious + safe to me.
Thanks,
Jan
gdb/
2011-02-21 Jan Kratochvil <jan.kratochvil@redhat.com>
* common/Makefile.in (CFLAGS): New.
(COMPILE): Add $(CFLAGS).
--- a/gdb/common/Makefile.in
+++ b/gdb/common/Makefile.in
@@ -23,6 +23,10 @@ AUTOHEADER = @AUTOHEADER@
RANLIB = @RANLIB@
COMMON_CPU_OBJ = @COMMON_CPU_OBJ@
+# CFLAGS is specifically reserved for setting from the command line
+# when running make. I.E. "make CFLAGS=-Wmissing-prototypes".
+CFLAGS = @CFLAGS@
+
BFD_DIR = ../../bfd
BFD_SRC = $(srcdir)/$(BFD_DIR)
BFD_CFLAGS = -I$(BFD_DIR) -I$(BFD_SRC)
@@ -37,7 +41,8 @@ all: libcommon.a
signals.o: $(srcdir)/signals.c
$(COMPILE) $(srcdir)/signals.c
-COMPILE = source='$<' object='$@' libtool=no $(CC) $(DEFS) $(INCLUDES) @GDB_FLAGS@ $(CPPFLAGS) $(ALL_CFLAGS) -c
+COMPILE = source='$<' object='$@' libtool=no $(CC) $(DEFS) $(INCLUDES) \
+ @GDB_FLAGS@ $(CPPFLAGS) $(ALL_CFLAGS) $(CFLAGS) -c
# Implicit rules
next prev parent reply other threads:[~2011-02-21 18:45 UTC|newest]
Thread overview: 94+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-15 0:52 [rfa/rfc] Build libcommon.a for gdb and gdbserver Yao Qi
2011-01-15 0:57 ` Pedro Alves
2011-01-17 17:11 ` Tom Tromey
2011-01-17 18:41 ` Joel Brobecker
2011-01-18 0:42 ` Yao Qi
2011-01-18 5:20 ` Pedro Alves
2011-01-18 15:29 ` Tom Tromey
2011-01-19 23:26 ` Yao Qi
2011-01-28 15:04 ` Tom Tromey
2011-01-28 15:22 ` Pedro Alves
2011-01-28 15:52 ` Pedro Alves
2011-02-03 21:30 ` Tom Tromey
2011-02-11 9:58 ` Yao Qi
2011-02-11 18:47 ` Tom Tromey
2011-02-12 3:13 ` Yao Qi
2011-02-14 14:50 ` Tom Tromey
2011-02-14 15:19 ` Tom Tromey
2011-02-14 17:43 ` Pierre Muller
2011-02-14 17:58 ` Pierre Muller
2011-02-14 18:22 ` Tom Tromey
2011-02-14 19:31 ` Change gdb/common/ to use Automake [was: Re: [rfa/rfc] Build libcommon.a for gdb and gdbserver] Pedro Alves
2011-02-14 19:39 ` Change gdb/common/ to use Automake Tom Tromey
2011-02-14 20:13 ` Pedro Alves
2011-02-14 20:14 ` Tom Tromey
2011-02-15 6:46 ` Joel Brobecker
2011-02-18 23:59 ` Doug Evans
2011-02-14 22:11 ` Tom Tromey
2011-02-14 23:16 ` Pedro Alves
2011-02-18 19:54 ` Tom Tromey
2011-02-23 7:21 ` Yao Qi
2011-02-23 17:24 ` Tom Tromey
2011-02-15 13:08 ` [rfa/rfc] Build libcommon.a for gdb and gdbserver Pierre Muller
2011-02-15 13:20 ` Pierre Muller
2011-02-18 16:15 ` Tom Tromey
2011-02-18 16:58 ` Pierre Muller
2011-02-18 15:53 ` Tom Tromey
2011-02-23 5:26 ` Yao Qi
2011-02-23 16:38 ` Tom Tromey
2011-02-23 17:42 ` Tom Tromey
2011-02-23 18:05 ` Joel Brobecker
2011-02-23 18:31 ` Joel Brobecker
2011-02-23 18:47 ` Pedro Alves
2011-02-23 20:22 ` Tom Tromey
2011-02-23 20:28 ` Pedro Alves
2011-02-23 20:36 ` Tom Tromey
2011-02-23 20:57 ` Pedro Alves
2011-02-24 3:58 ` Yao Qi
2011-02-28 18:10 ` Tom Tromey
2011-03-01 4:42 ` Joel Brobecker
2011-03-01 5:46 ` Yao Qi
2011-03-01 10:52 ` Joel Brobecker
2011-03-01 14:36 ` Tom Tromey
2011-03-02 4:41 ` Yao Qi
2011-03-02 14:38 ` Tom Tromey
2011-03-03 6:00 ` Yao Qi
2011-02-15 8:11 ` Yao Qi
2011-01-31 2:01 ` Yao Qi
2011-02-12 13:06 ` Yao Qi
2011-02-15 13:54 ` Jan Kratochvil
2011-02-15 15:32 ` Yao Qi
2011-02-15 21:07 ` Jan Kratochvil
2011-02-15 21:18 ` [obv] Merge gdb/common/Changelog to gdb/ChangeLog [Re: [rfa/rfc] Build libcommon.a for gdb and gdbserver] Jan Kratochvil
2011-02-16 1:54 ` Yao Qi
2011-02-16 6:55 ` Jan Kratochvil
2011-02-16 8:38 ` Stan Shebs
2011-02-16 18:17 ` Michael Snyder
2011-02-16 19:40 ` Tom Tromey
2011-02-16 19:47 ` Michael Snyder
2011-02-16 19:57 ` Tom Tromey
2011-02-16 20:18 ` Michael Snyder
2011-02-17 4:03 ` Yao Qi
2011-02-16 22:03 ` Stan Shebs
2011-02-17 19:02 ` Frank Ch. Eigler
2011-02-16 16:49 ` Tom Tromey
2011-02-18 18:49 ` [rfa/rfc] Build libcommon.a for gdb and gdbserver Tom Tromey
2011-02-19 12:35 ` Joel Brobecker
2011-02-19 13:20 ` Andreas Tobler
2011-02-19 13:50 ` Mark Kettenis
2011-02-19 17:24 ` Joel Brobecker
2011-02-19 18:01 ` Mark Kettenis
2011-02-21 6:31 ` Pedro Alves
2011-02-23 21:53 ` Mark Kettenis
2011-02-23 22:50 ` Pedro Alves
2011-02-23 23:50 ` Pedro Alves
2011-03-06 17:23 ` Jan Kratochvil
2011-03-06 18:23 ` Mark Kettenis
2011-03-06 18:28 ` Andreas Schwab
2011-03-06 22:44 ` [patch] Fix Solaris make gdb/data-directory/ compat. [Re: [rfa/rfc] Build libcommon.a for gdb and gdbserver] Jan Kratochvil
2011-03-07 4:28 ` Yao Qi
2011-03-07 4:35 ` Jan Kratochvil
2011-03-07 16:50 ` Tom Tromey
2011-02-21 18:58 ` Jan Kratochvil [this message]
2011-02-21 20:09 ` [patch] Regression on CFLAGS=-m32 build " Jan Kratochvil
2011-01-18 0:45 ` [rfa/rfc] Build libcommon.a for gdb and gdbserver Pedro Alves
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110221184444.GA4349@host1.dyn.jankratochvil.net \
--to=jan.kratochvil@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=tromey@redhat.com \
--cc=yao@codesourcery.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox