From: Tom Tromey <tromey@redhat.com>
To: Yao Qi <yao@codesourcery.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [rfa/rfc] Build libcommon.a for gdb and gdbserver
Date: Fri, 28 Jan 2011 15:04:00 -0000 [thread overview]
Message-ID: <m3fwsdf5ad.fsf@fleche.redhat.com> (raw)
In-Reply-To: <4D375F44.70504@codesourcery.com> (Yao Qi's message of "Wed, 19 Jan 2011 15:01:40 -0700")
Tom> Another idea would be to just have gdb/configure, but have a special
Tom> Makefile target that only builds gdbserver. Then all the configury
Tom> would be unified; maybe this is the best option, for that reason.
Yao> I thought of this, but it makes gdb/configure in mess when we move
Yao> everything to gdb/configure. Finally, IMO, it is better to create
Yao> separate Makefile.in/configure.ac in common/, whic scales well when we
Yao> move more files to common/ later.
I think gdb/configure is already pretty messy. It is more than 2000
lines of code. A few more for gdbserver aren't going to hurt much, IMO.
The problem I have with adding another configure script is that
presumably it must arrive at all the same conclusions as both gdb and
gdbserver's configure scripts. That means either maintaining things in
parallel -- which will be fragile -- or putting a bunch of code into
shared .m4 files. But then... why run that same code multiple times,
when we can just do it once?
Yao> 3. Including different headers when building libcommon.a for gdb and
Yao> gdbserver.
I don't understand this. I didn't see it in the patch.
Yao> 4 Building libcommon.a for gdb and gdbserver respectively.
This seems to mean that we must build libcommon twice. I don't
understand that -- what is the benefit, versus having a single library?
Yao> diff --git a/gdb/Makefile.in b/gdb/Makefile.in
[...]
Yao> +$(LIBCOMMON): $(LIBCOMMON_DIR)/Makefile
Yao> + @$(MAKE) $(FLAGS_TO_PASS) DO=all DODIRS=common subdir_do
Yao> +
Yao> +configure-common:
Yao> + @: $(MAKE); $(unstage)
Yao> + @r=`${PWD_COMMAND}`; export r; \
Yao> + s=`cd $(srcdir); ${PWD_COMMAND}`; export s; \
I believe gdb/configure will take care of this, because `common' is now
in AC_CONFIG_SUBDIRS.
Tom
next prev parent reply other threads:[~2011-01-28 14:54 UTC|newest]
Thread overview: 94+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-15 0:52 Yao Qi
2011-01-15 0:57 ` Pedro Alves
2011-01-17 17:11 ` Tom Tromey
2011-01-17 18:41 ` Joel Brobecker
2011-01-18 0:42 ` Yao Qi
2011-01-18 5:20 ` Pedro Alves
2011-01-18 15:29 ` Tom Tromey
2011-01-19 23:26 ` Yao Qi
2011-01-28 15:04 ` Tom Tromey [this message]
2011-01-28 15:22 ` Pedro Alves
2011-01-28 15:52 ` Pedro Alves
2011-02-03 21:30 ` Tom Tromey
2011-02-11 9:58 ` Yao Qi
2011-02-11 18:47 ` Tom Tromey
2011-02-12 3:13 ` Yao Qi
2011-02-14 14:50 ` Tom Tromey
2011-02-14 15:19 ` Tom Tromey
2011-02-14 17:43 ` Pierre Muller
2011-02-14 17:58 ` Pierre Muller
2011-02-14 18:22 ` Tom Tromey
2011-02-14 19:31 ` Change gdb/common/ to use Automake [was: Re: [rfa/rfc] Build libcommon.a for gdb and gdbserver] Pedro Alves
2011-02-14 19:39 ` Change gdb/common/ to use Automake Tom Tromey
2011-02-14 20:13 ` Pedro Alves
2011-02-14 20:14 ` Tom Tromey
2011-02-15 6:46 ` Joel Brobecker
2011-02-18 23:59 ` Doug Evans
2011-02-14 22:11 ` Tom Tromey
2011-02-14 23:16 ` Pedro Alves
2011-02-18 19:54 ` Tom Tromey
2011-02-23 7:21 ` Yao Qi
2011-02-23 17:24 ` Tom Tromey
2011-02-15 13:08 ` [rfa/rfc] Build libcommon.a for gdb and gdbserver Pierre Muller
2011-02-15 13:20 ` Pierre Muller
2011-02-18 16:15 ` Tom Tromey
2011-02-18 16:58 ` Pierre Muller
2011-02-18 15:53 ` Tom Tromey
2011-02-23 5:26 ` Yao Qi
2011-02-23 16:38 ` Tom Tromey
2011-02-23 17:42 ` Tom Tromey
2011-02-23 18:05 ` Joel Brobecker
2011-02-23 18:31 ` Joel Brobecker
2011-02-23 18:47 ` Pedro Alves
2011-02-23 20:22 ` Tom Tromey
2011-02-23 20:28 ` Pedro Alves
2011-02-23 20:36 ` Tom Tromey
2011-02-23 20:57 ` Pedro Alves
2011-02-24 3:58 ` Yao Qi
2011-02-28 18:10 ` Tom Tromey
2011-03-01 4:42 ` Joel Brobecker
2011-03-01 5:46 ` Yao Qi
2011-03-01 10:52 ` Joel Brobecker
2011-03-01 14:36 ` Tom Tromey
2011-03-02 4:41 ` Yao Qi
2011-03-02 14:38 ` Tom Tromey
2011-03-03 6:00 ` Yao Qi
2011-02-15 8:11 ` Yao Qi
2011-01-31 2:01 ` Yao Qi
2011-02-12 13:06 ` Yao Qi
2011-02-15 13:54 ` Jan Kratochvil
2011-02-15 15:32 ` Yao Qi
2011-02-15 21:07 ` Jan Kratochvil
2011-02-15 21:18 ` [obv] Merge gdb/common/Changelog to gdb/ChangeLog [Re: [rfa/rfc] Build libcommon.a for gdb and gdbserver] Jan Kratochvil
2011-02-16 1:54 ` Yao Qi
2011-02-16 6:55 ` Jan Kratochvil
2011-02-16 8:38 ` Stan Shebs
2011-02-16 18:17 ` Michael Snyder
2011-02-16 19:40 ` Tom Tromey
2011-02-16 19:47 ` Michael Snyder
2011-02-16 19:57 ` Tom Tromey
2011-02-16 20:18 ` Michael Snyder
2011-02-17 4:03 ` Yao Qi
2011-02-16 22:03 ` Stan Shebs
2011-02-17 19:02 ` Frank Ch. Eigler
2011-02-16 16:49 ` Tom Tromey
2011-02-18 18:49 ` [rfa/rfc] Build libcommon.a for gdb and gdbserver Tom Tromey
2011-02-19 12:35 ` Joel Brobecker
2011-02-19 13:20 ` Andreas Tobler
2011-02-19 13:50 ` Mark Kettenis
2011-02-19 17:24 ` Joel Brobecker
2011-02-19 18:01 ` Mark Kettenis
2011-02-21 6:31 ` Pedro Alves
2011-02-23 21:53 ` Mark Kettenis
2011-02-23 22:50 ` Pedro Alves
2011-02-23 23:50 ` Pedro Alves
2011-03-06 17:23 ` Jan Kratochvil
2011-03-06 18:23 ` Mark Kettenis
2011-03-06 18:28 ` Andreas Schwab
2011-03-06 22:44 ` [patch] Fix Solaris make gdb/data-directory/ compat. [Re: [rfa/rfc] Build libcommon.a for gdb and gdbserver] Jan Kratochvil
2011-03-07 4:28 ` Yao Qi
2011-03-07 4:35 ` Jan Kratochvil
2011-03-07 16:50 ` Tom Tromey
2011-02-21 18:58 ` [patch] Regression on CFLAGS=-m32 build " Jan Kratochvil
2011-02-21 20:09 ` Jan Kratochvil
2011-01-18 0:45 ` [rfa/rfc] Build libcommon.a for gdb and gdbserver Pedro Alves
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m3fwsdf5ad.fsf@fleche.redhat.com \
--to=tromey@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=yao@codesourcery.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox