From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 3645 invoked by alias); 1 Mar 2011 05:46:39 -0000 Received: (qmail 3635 invoked by uid 22791); 1 Mar 2011 05:46:37 -0000 X-SWARE-Spam-Status: No, hits=-1.8 required=5.0 tests=AWL,BAYES_00,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mail.codesourcery.com (HELO mail.codesourcery.com) (38.113.113.100) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 01 Mar 2011 05:46:26 +0000 Received: (qmail 23114 invoked from network); 1 Mar 2011 05:46:24 -0000 Received: from unknown (HELO ?192.168.0.101?) (yao@127.0.0.2) by mail.codesourcery.com with ESMTPA; 1 Mar 2011 05:46:24 -0000 Message-ID: <4D6C882B.7010801@codesourcery.com> Date: Tue, 01 Mar 2011 05:46:00 -0000 From: Yao Qi User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.2.13) Gecko/20101208 Lightning/1.0b2 Thunderbird/3.1.7 MIME-Version: 1.0 To: Joel Brobecker CC: Tom Tromey , Pedro Alves , gdb-patches@sourceware.org Subject: Re: [rfa/rfc] Build libcommon.a for gdb and gdbserver References: <4D550834.6080807@codesourcery.com> <4D55FAB4.7090001@codesourcery.com> <4D648A5F.8050607@codesourcery.com> <4D65D5B7.1000902@codesourcery.com> <20110301044144.GH30306@adacore.com> In-Reply-To: <20110301044144.GH30306@adacore.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2011-03/txt/msg00018.txt.bz2 On 03/01/2011 12:41 PM, Joel Brobecker wrote: >> Yao> Personally, I still prefer a separated configure/makefile in common/, >> Yao> because, >> Yao> 1. if my patch works, configure/make is not a problem, >> Yao> 2. if we look forward, there should be quite a few *.c and *.h files in >> Yao> common in the future. Write rules in both gdb/Makefile.in and >> Yao> gdbserver/Makefile.in doesn't scale. >> >> I think the most important thing is that if you want to keep the >> common/configure stuff, then please fix the existing problems that have >> been reported. Maybe it is just the GNU make-ism at this point, I >> haven't kept track. > > On my end of things, I actually do not like the multiple layers of > miniature configure scripts. These things just keep doing the same > checks over and over for the most part. It's particularly visible > on Windows, were configure takes ages because spawning a script is > utterly inefficient. (and as such, Tom's proposal to remove the > configure script in gdb/testsuite seems like a good idea to me too) > > That being said, as long as it works, it's not of uber importance > to me but I am not certain that argument number 2 above from Yao > really is that much work. So, if we fix things fast, I do not mind > continuing with the present approach. (does anyone know what the > remaining issues are, though?) > AFAIK, there are three problems, 1. Build failure on mingw32, reported by Pierre. See I'll give a patch to fix this. 2. make clean doesn't run in gdbserver/common, reported by Michael. http://sourceware.org/ml/gdb/2011-02/msg00126.html Patch was sent to the wrong place. I'll send it again to gdb-patches@. 3. GNU make feature, http://sourceware.org/ml/gdb-patches/2011-02/msg00489.html Since we decide not to require GNU make, I'll remove its GNU make feature. Am I missing any problems else? -- Yao (齐尧)