From: Michael Snyder <msnyder@vmware.com>
To: Mark Kettenis <mark.kettenis@xs4all.nl>
Cc: "gdb-patches@sourceware.org" <gdb-patches@sourceware.org>
Subject: Re: [commit] Document that case statement fall-through is intentional.
Date: Sat, 26 Feb 2011 22:52:00 -0000 [thread overview]
Message-ID: <4D69839A.1080707@vmware.com> (raw)
In-Reply-To: <201102262231.p1QMVCbB011727@glazunov.sibelius.xs4all.nl>
Mark Kettenis wrote:
>> Date: Sat, 26 Feb 2011 13:52:18 -0800
>> From: Michael Snyder <msnyder@vmware.com>
>>
>> Tested with "set debug expression 1" -- and I'm telling you, it took me
>> a while to figure THAT out!
>>
>>
>> --------------070307060603090205010008
>> Content-Type: text/plain;
>> name="dump.txt"
>> Content-Transfer-Encoding: 7bit
>> Content-Disposition: inline;
>> filename="dump.txt"
>>
>> 2011-02-26 Michael Snyder <msnyder@vmware.com>
>>
>> * expprint.c (dump_subexp_body_standard): Document that case
>> statement is meant to fall through.
>>
>> Index: expprint.c
>> ===================================================================
>> RCS file: /cvs/src/src/gdb/expprint.c,v
>> retrieving revision 1.50
>> diff -u -p -u -p -r1.50 expprint.c
>> --- expprint.c 1 Feb 2011 18:56:34 -0000 1.50
>> +++ expprint.c 26 Feb 2011 21:48:49 -0000
>> @@ -767,6 +767,7 @@ dump_subexp_body_standard (struct expres
>> case TERNOP_SLICE:
>> case TERNOP_SLICE_COUNT:
>> elt = dump_subexp (exp, stream, elt);
>> + /* FALL THROUGH */
>
> proper spelling is /* FALLTHROUGH */, at least that's what the classic
> lint tool wants.
Thanks!
prev parent reply other threads:[~2011-02-26 22:50 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-02-26 22:06 Michael Snyder
2011-02-26 22:40 ` Mark Kettenis
2011-02-26 22:52 ` Michael Snyder [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D69839A.1080707@vmware.com \
--to=msnyder@vmware.com \
--cc=gdb-patches@sourceware.org \
--cc=mark.kettenis@xs4all.nl \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox