From: Michael Snyder <msnyder@vmware.com>
To: "gdb-patches@sourceware.org" <gdb-patches@sourceware.org>
Subject: [commit] Document that case statement fall-through is intentional.
Date: Sat, 26 Feb 2011 22:06:00 -0000 [thread overview]
Message-ID: <4D697612.9050507@vmware.com> (raw)
[-- Attachment #1: Type: text/plain, Size: 101 bytes --]
Tested with "set debug expression 1" -- and I'm telling you, it took me
a while to figure THAT out!
[-- Attachment #2: dump.txt --]
[-- Type: text/plain, Size: 932 bytes --]
2011-02-26 Michael Snyder <msnyder@vmware.com>
* expprint.c (dump_subexp_body_standard): Document that case
statement is meant to fall through.
Index: expprint.c
===================================================================
RCS file: /cvs/src/src/gdb/expprint.c,v
retrieving revision 1.50
diff -u -p -u -p -r1.50 expprint.c
--- expprint.c 1 Feb 2011 18:56:34 -0000 1.50
+++ expprint.c 26 Feb 2011 21:48:49 -0000
@@ -767,6 +767,7 @@ dump_subexp_body_standard (struct expres
case TERNOP_SLICE:
case TERNOP_SLICE_COUNT:
elt = dump_subexp (exp, stream, elt);
+ /* FALL THROUGH */
case BINOP_ADD:
case BINOP_SUB:
case BINOP_MUL:
@@ -803,6 +804,7 @@ dump_subexp_body_standard (struct expres
case STRUCTOP_MEMBER:
case STRUCTOP_MPTR:
elt = dump_subexp (exp, stream, elt);
+ /* FALL THROUGH */
case UNOP_NEG:
case UNOP_LOGICAL_NOT:
case UNOP_COMPLEMENT:
next reply other threads:[~2011-02-26 21:52 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-02-26 22:06 Michael Snyder [this message]
2011-02-26 22:40 ` Mark Kettenis
2011-02-26 22:52 ` Michael Snyder
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D697612.9050507@vmware.com \
--to=msnyder@vmware.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox