From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 9975 invoked by alias); 26 Feb 2011 21:52:26 -0000 Received: (qmail 9966 invoked by uid 22791); 26 Feb 2011 21:52:26 -0000 X-SWARE-Spam-Status: No, hits=-4.9 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from smtp-outbound-2.vmware.com (HELO smtp-outbound-2.vmware.com) (65.115.85.73) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Sat, 26 Feb 2011 21:52:21 +0000 Received: from mailhost2.vmware.com (mailhost2.vmware.com [10.16.67.167]) by smtp-outbound-2.vmware.com (Postfix) with ESMTP id 637F63F003 for ; Sat, 26 Feb 2011 13:52:18 -0800 (PST) Received: from msnyder-server.eng.vmware.com (promd-2s-dhcp138.eng.vmware.com [10.20.124.138]) by mailhost2.vmware.com (Postfix) with ESMTP id 5EE8D8EE95 for ; Sat, 26 Feb 2011 13:52:18 -0800 (PST) Message-ID: <4D697612.9050507@vmware.com> Date: Sat, 26 Feb 2011 22:06:00 -0000 From: Michael Snyder User-Agent: Thunderbird 2.0.0.24 (X11/20101201) MIME-Version: 1.0 To: "gdb-patches@sourceware.org" Subject: [commit] Document that case statement fall-through is intentional. Content-Type: multipart/mixed; boundary="------------070307060603090205010008" X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2011-02/txt/msg00803.txt.bz2 This is a multi-part message in MIME format. --------------070307060603090205010008 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Content-length: 101 Tested with "set debug expression 1" -- and I'm telling you, it took me a while to figure THAT out! --------------070307060603090205010008 Content-Type: text/plain; name="dump.txt" Content-Transfer-Encoding: 7bit Content-Disposition: inline; filename="dump.txt" Content-length: 932 2011-02-26 Michael Snyder * expprint.c (dump_subexp_body_standard): Document that case statement is meant to fall through. Index: expprint.c =================================================================== RCS file: /cvs/src/src/gdb/expprint.c,v retrieving revision 1.50 diff -u -p -u -p -r1.50 expprint.c --- expprint.c 1 Feb 2011 18:56:34 -0000 1.50 +++ expprint.c 26 Feb 2011 21:48:49 -0000 @@ -767,6 +767,7 @@ dump_subexp_body_standard (struct expres case TERNOP_SLICE: case TERNOP_SLICE_COUNT: elt = dump_subexp (exp, stream, elt); + /* FALL THROUGH */ case BINOP_ADD: case BINOP_SUB: case BINOP_MUL: @@ -803,6 +804,7 @@ dump_subexp_body_standard (struct expres case STRUCTOP_MEMBER: case STRUCTOP_MPTR: elt = dump_subexp (exp, stream, elt); + /* FALL THROUGH */ case UNOP_NEG: case UNOP_LOGICAL_NOT: case UNOP_COMPLEMENT: --------------070307060603090205010008--