From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-78744-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 16439 invoked by alias); 26 Feb 2011 22:50:09 -0000
Received: (qmail 16428 invoked by uid 22791); 26 Feb 2011 22:50:08 -0000
X-SWARE-Spam-Status: No, hits=-4.9 required=5.0	tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,T_RP_MATCHES_RCVD
X-Spam-Check-By: sourceware.org
Received: from smtp-outbound-1.vmware.com (HELO smtp-outbound-1.vmware.com) (65.115.85.69)    by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Sat, 26 Feb 2011 22:50:04 +0000
Received: from mailhost2.vmware.com (mailhost2.vmware.com [10.16.67.167])	by smtp-outbound-1.vmware.com (Postfix) with ESMTP id E15AE1C009;	Sat, 26 Feb 2011 14:50:02 -0800 (PST)
Received: from msnyder-server.eng.vmware.com (promd-2s-dhcp138.eng.vmware.com [10.20.124.138])	by mailhost2.vmware.com (Postfix) with ESMTP id D7D048EEA4;	Sat, 26 Feb 2011 14:50:02 -0800 (PST)
Message-ID: <4D69839A.1080707@vmware.com>
Date: Sat, 26 Feb 2011 22:52:00 -0000
From: Michael Snyder <msnyder@vmware.com>
User-Agent: Thunderbird 2.0.0.24 (X11/20101201)
MIME-Version: 1.0
To: Mark Kettenis <mark.kettenis@xs4all.nl>
CC: "gdb-patches@sourceware.org" <gdb-patches@sourceware.org>
Subject: Re: [commit] Document that case statement fall-through is intentional.
References: <4D697612.9050507@vmware.com> <201102262231.p1QMVCbB011727@glazunov.sibelius.xs4all.nl>
In-Reply-To: <201102262231.p1QMVCbB011727@glazunov.sibelius.xs4all.nl>
Content-Type: text/plain; charset=iso-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
X-IsSubscribed: yes
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2011-02/txt/msg00811.txt.bz2

Mark Kettenis wrote:
>> Date: Sat, 26 Feb 2011 13:52:18 -0800
>> From: Michael Snyder <msnyder@vmware.com>
>>
>> Tested with "set debug expression 1" -- and I'm telling you, it took me
>> a while to figure THAT out!
>>
>>
>> --------------070307060603090205010008
>> Content-Type: text/plain;
>>  name="dump.txt"
>> Content-Transfer-Encoding: 7bit
>> Content-Disposition: inline;
>>  filename="dump.txt"
>>
>> 2011-02-26  Michael Snyder  <msnyder@vmware.com>
>>
>> 	* expprint.c (dump_subexp_body_standard): Document that case
>> 	statement is meant to fall through.
>>
>> Index: expprint.c
>> ===================================================================
>> RCS file: /cvs/src/src/gdb/expprint.c,v
>> retrieving revision 1.50
>> diff -u -p -u -p -r1.50 expprint.c
>> --- expprint.c	1 Feb 2011 18:56:34 -0000	1.50
>> +++ expprint.c	26 Feb 2011 21:48:49 -0000
>> @@ -767,6 +767,7 @@ dump_subexp_body_standard (struct expres
>>      case TERNOP_SLICE:
>>      case TERNOP_SLICE_COUNT:
>>        elt = dump_subexp (exp, stream, elt);
>> +      /* FALL THROUGH */
> 
> proper spelling is /* FALLTHROUGH */, at least that's what the classic
> lint tool wants.

Thanks!