Re: [commit] Document that case statement fall-through is intentional.

Michael Snyder
2011-02-26T22:50:09Z

Mark Kettenis wrote:
>> Date: Sat, 26 Feb 2011 13:52:18 -0800
>> From: Michael Snyder <msnyder@vmware.com>
>>
>> Tested with "set debug expression 1" -- and I'm telling you, it took me
>> a while to figure THAT out!
>>
>>
>> --------------070307060603090205010008
>> Content-Type: text/plain;
>> name="dump.txt"
>> Content-Transfer-Encoding: 7bit
>> Content-Disposition: inline;
>> filename="dump.txt"
>>
>> 2011-02-26 Michael Snyder <msnyder@vmware.com>
>>
>> * expprint.c (dump_subexp_body_standard): Document that case
>> statement is meant to fall through.
>>
>> Index: expprint.c
>> ===================================================================
>> RCS file: /cvs/src/src/gdb/expprint.c,v
>> retrieving revision 1.50
>> diff -u -p -u -p -r1.50 expprint.c
>> --- expprint.c 1 Feb 2011 18:56:34 -0000 1.50
>> +++ expprint.c 26 Feb 2011 21:48:49 -0000
>> @@ -767,6 +767,7 @@ dump_subexp_body_standard (struct expres
>> case TERNOP_SLICE:
>> case TERNOP_SLICE_COUNT:
>> elt = dump_subexp (exp, stream, elt);
>> + /* FALL THROUGH */
>
> proper spelling is /* FALLTHROUGH */, at least that's what the classic
> lint tool wants.

Thanks!