[rfa] make clean should remove observe.h and observer.inc

[rfa] make clean should remove observe.h and observer.inc

[Michael Snyder]

[-- Attachment #1: Type: text/plain, Size: 31 bytes --]

These are easily regenerated.


[-- Attachment #2: observer.txt --]
[-- Type: text/plain, Size: 810 bytes --]

2011-02-22  Michael Snyder  <msnyder@vmware.com>

	* Makefile.in (clean): Make clean should remove generated files
	observer.h and observer.inc.

Index: Makefile.in
===================================================================
RCS file: /cvs/src/src/gdb/Makefile.in,v
retrieving revision 1.1158
diff -u -p -u -p -r1.1158 Makefile.in
--- Makefile.in	22 Feb 2011 08:00:25 -0000	1.1158
+++ Makefile.in	22 Feb 2011 21:22:37 -0000
@@ -1237,7 +1237,7 @@ tags: TAGS
 clean mostlyclean: $(CONFIG_CLEAN)
 	@$(MAKE) $(FLAGS_TO_PASS) DO=clean "DODIRS=$(CLEANDIRS)" subdir_do
 	rm -f *.o *.a $(ADD_FILES) *~ init.c-tmp init.l-tmp version.c-tmp
-	rm -f init.c version.c
+	rm -f init.c version.c observer.h observer.inc
 	rm -f gdb$(EXEEXT) core make.log
 	rm -f gdb[0-9]$(EXEEXT)
 	rm -f test-cp-name-parser$(EXEEXT)

Re: [rfa] make clean should remove observe.h and observer.inc

[Michael Snyder]

[-- Attachment #1: Type: text/plain, Size: 109 bytes --]

Did this show up on the list?  I can't find it...

Michael Snyder wrote:
> These are easily regenerated.
> 


[-- Attachment #2: observer.txt --]
[-- Type: text/plain, Size: 810 bytes --]

2011-02-23  Michael Snyder  <msnyder@vmware.com>

	* Makefile.in (clean): Make clean should remove generated files
	observer.h and observer.inc.

Index: Makefile.in
===================================================================
RCS file: /cvs/src/src/gdb/Makefile.in,v
retrieving revision 1.1158
diff -u -p -u -p -r1.1158 Makefile.in
--- Makefile.in	22 Feb 2011 08:00:25 -0000	1.1158
+++ Makefile.in	23 Feb 2011 21:33:33 -0000
@@ -1237,7 +1237,7 @@ tags: TAGS
 clean mostlyclean: $(CONFIG_CLEAN)
 	@$(MAKE) $(FLAGS_TO_PASS) DO=clean "DODIRS=$(CLEANDIRS)" subdir_do
 	rm -f *.o *.a $(ADD_FILES) *~ init.c-tmp init.l-tmp version.c-tmp
-	rm -f init.c version.c
+	rm -f init.c version.c observer.h observer.inc
 	rm -f gdb$(EXEEXT) core make.log
 	rm -f gdb[0-9]$(EXEEXT)
 	rm -f test-cp-name-parser$(EXEEXT)

Re: [rfa] make clean should remove observe.h and observer.inc

[Jan Kratochvil]

On Wed, 23 Feb 2011 22:35:47 +0100, Michael Snyder wrote:
> Did this show up on the list?  I can't find it...

Yes.  I do not see any problem with the mail delivery.
	http://sourceware.org/ml/gdb-patches/2011-02/msg00627.html


Regards,
Jan

Re: [rfa] make clean should remove observe.h and observer.inc

[Tom Tromey]

Michael> 2011-02-23  Michael Snyder  <msnyder@vmware.com>
Michael> 	* Makefile.in (clean): Make clean should remove generated files
Michael> 	observer.h and observer.inc.

I think this is ok.

There is a sort of GNU rule governing "clean" behavior.  I'm not sure
whether this is documented in the GNU standards but it is longstanding
practice, existing before and then codified in Automake:

* 'mostlyclean' is a "useful" subset of 'clean'
* If 'make' built it, 'clean' removes it
* If 'configure' built it, 'distclean' removes it
* If the developer built it, but it is a generated file not needed for
  "configure; make", then `maintainer-clean' removes it.

I looked a little more and I found this in the Automake manual's "Clean"
node.

Tom

Re: [rfa] make clean should remove observe.h and observer.inc

[Michael Snyder]

Tom Tromey wrote:
> Michael> 2011-02-23  Michael Snyder  <msnyder@vmware.com>
> Michael> 	* Makefile.in (clean): Make clean should remove generated files
> Michael> 	observer.h and observer.inc.
> 
> I think this is ok.

I'll check it in, then,

> There is a sort of GNU rule governing "clean" behavior.  I'm not sure
> whether this is documented in the GNU standards but it is longstanding
> practice, existing before and then codified in Automake:
> 
> * 'mostlyclean' is a "useful" subset of 'clean'
> * If 'make' built it, 'clean' removes it
> * If 'configure' built it, 'distclean' removes it
> * If the developer built it, but it is a generated file not needed for
>   "configure; make", then `maintainer-clean' removes it.
> 
> I looked a little more and I found this in the Automake manual's "Clean"
> node.

That brings up another question.  What about <lang>-exp.c?  Technically
they are generated files.  Should make clean remove them?

Re: [rfa] make clean should remove observe.h and observer.inc

[Joel Brobecker]

> That brings up another question.  What about <lang>-exp.c?  Technically
> they are generated files.  Should make clean remove them?

I would say no - we check them in so to allow users to build
GDB without requiring bison/flex. It would be problematic for
them if they disappeared at a simple "make clean".

-- 
Joel

Re: [rfa] make clean should remove observe.h and observer.inc

[Michael Snyder]

Joel Brobecker wrote:
>> That brings up another question.  What about <lang>-exp.c?  Technically
>> they are generated files.  Should make clean remove them?
> 
> I would say no - we check them in so to allow users to build
> GDB without requiring bison/flex. It would be problematic for
> them if they disappeared at a simple "make clean".
> 

We don't check them in -- they're not in cvs.  We add them to the tar 
file when we make a release.

OK, though, how about "make distclean"?

Re: [rfa] make clean should remove observe.h and observer.inc

[Tom Tromey]

>>>>> "Michael" == Michael Snyder <msnyder@vmware.com> writes:

Michael> We don't check them in -- they're not in cvs.  We add them to
Michael> the tar file when we make a release.

Michael> OK, though, how about "make distclean"?

Another meaning of "distclean" is "make the tree look like it did after
I unpacked the distribution .tar".

So, this is sort of a funny case.  I think if you really want them to be
removed, distclean would be fine.

Tom

Re: [rfa] make clean should remove observe.h and observer.inc

[Mark Kettenis]

> Date: Thu, 24 Feb 2011 10:27:44 -0800
> From: Michael Snyder <msnyder@vmware.com>
> 
> Joel Brobecker wrote:
> >> That brings up another question.  What about <lang>-exp.c?  Technically
> >> they are generated files.  Should make clean remove them?
> > 
> > I would say no - we check them in so to allow users to build
> > GDB without requiring bison/flex. It would be problematic for
> > them if they disappeared at a simple "make clean".
> > 
> 
> We don't check them in -- they're not in cvs.  We add them to the tar 
> file when we make a release.
> 
> OK, though, how about "make distclean"?

Same for "make distclean"; "make distclean" should restore the source
tree into the state it was in just after untarring the GDB release
tarball.

Re: [rfa] make clean should remove observe.h and observer.inc

[Mark Kettenis]

> Date: Thu, 24 Feb 2011 22:25:46 +0400
> From: Joel Brobecker <brobecker@adacore.com>
> 
> > That brings up another question.  What about <lang>-exp.c?  Technically
> > they are generated files.  Should make clean remove them?
> 
> I would say no - we check them in so to allow users to build
> GDB without requiring bison/flex. It would be problematic for
> them if they disappeared at a simple "make clean".

Indeed; "make clean" should not remove any files that are included in
the GDB release tarball.