From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 13644 invoked by alias); 24 Feb 2011 18:04:12 -0000 Received: (qmail 13636 invoked by uid 22791); 24 Feb 2011 18:04:11 -0000 X-SWARE-Spam-Status: No, hits=-4.9 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from smtp-outbound-2.vmware.com (HELO smtp-outbound-2.vmware.com) (65.115.85.73) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 24 Feb 2011 18:04:06 +0000 Received: from mailhost4.vmware.com (mailhost4.vmware.com [10.16.67.124]) by smtp-outbound-2.vmware.com (Postfix) with ESMTP id 516E84E00E; Thu, 24 Feb 2011 10:04:03 -0800 (PST) Received: from msnyder-server.eng.vmware.com (promd-2s-dhcp138.eng.vmware.com [10.20.124.138]) by mailhost4.vmware.com (Postfix) with ESMTP id 4A5A9C9A4D; Thu, 24 Feb 2011 10:04:03 -0800 (PST) Message-ID: <4D669D92.2090005@vmware.com> Date: Thu, 24 Feb 2011 18:25:00 -0000 From: Michael Snyder User-Agent: Thunderbird 2.0.0.24 (X11/20101201) MIME-Version: 1.0 To: Tom Tromey CC: "gdb-patches@sourceware.org" Subject: Re: [rfa] make clean should remove observe.h and observer.inc References: <4D6429F5.3030209@vmware.com> <4D657DB3.80807@vmware.com> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2011-02/txt/msg00715.txt.bz2 Tom Tromey wrote: > Michael> 2011-02-23 Michael Snyder > Michael> * Makefile.in (clean): Make clean should remove generated files > Michael> observer.h and observer.inc. > > I think this is ok. I'll check it in, then, > There is a sort of GNU rule governing "clean" behavior. I'm not sure > whether this is documented in the GNU standards but it is longstanding > practice, existing before and then codified in Automake: > > * 'mostlyclean' is a "useful" subset of 'clean' > * If 'make' built it, 'clean' removes it > * If 'configure' built it, 'distclean' removes it > * If the developer built it, but it is a generated file not needed for > "configure; make", then `maintainer-clean' removes it. > > I looked a little more and I found this in the Automake manual's "Clean" > node. That brings up another question. What about -exp.c? Technically they are generated files. Should make clean remove them?