Re: [rfa] gdb.base/volatile.exp / varargs.exp: replace send_gdb with gdb_test

[Michael Snyder <msnyder@vmware.com>]

Joel Brobecker wrote:
> For the record, Michael and I were discussing privately by email,
> and one of the things I wrote was that he should feel free to commit
> if he feels confident about his patches.  Since this can be relatively
> mechanical, this should be relatively safe, and we can deal with
> adjustments using followup patches...
> 
>> 2010-05-19  Michael Snyder  <msnyder@vmware.com>
>>
>> 	* gdb.base/varargs.exp: Replace send_gdb with gdb_test.
>> 	* gdb.base/volatile.exp: Replace send_gdb with gdb_test.
> 
> Some questions/suggestions...
> 
>> -send_gdb "set print sevenbit-strings\n" ; gdb_expect -re "$gdb_prompt $"
>> -send_gdb "set print address off\n" ; gdb_expect -re "$gdb_prompt $"
>> -send_gdb "set width 0\n" ; gdb_expect -re "$gdb_prompt $"
>> +gdb_test "set print sevenbit-strings" "" \
>> +    "set print sevenbit-strings; ${testfile}"
>> +gdb_test "set print address off" "" \
>> +    "set print address off; ${testfile}"
>> +gdb_test "set width 0" "" \
>> +    "set width 0; ${testfile}"
> 
> Just wondering why you added the "testfile" at the end of the test
> description?

I copied it from an existing test.  My guess is that it
uniquifies the output, which otherwise would be identical
for a bunch of tests.

 > It does not seem to serve any purpose, and so yo should
> be able to simplify the above using:
> 
>> +gdb_test "set print sevenbit-strings" ""
>> +gdb_test "set print address off" ""
>> +gdb_test "set width 0" ""

Checking....  it seems that we have instances of at least four
different styles for these three specific statements.  I will
try to homogenize them.