From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-73136-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 29291 invoked by alias); 20 May 2010 18:02:43 -0000
Received: (qmail 29250 invoked by uid 22791); 20 May 2010 18:02:43 -0000
X-SWARE-Spam-Status: No, hits=-2.1 required=5.0	tests=AWL,BAYES_00,T_RP_MATCHES_RCVD
X-Spam-Check-By: sourceware.org
Received: from smtp-outbound-2.vmware.com (HELO smtp-outbound-2.vmware.com) (65.115.85.73)    by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 20 May 2010 18:02:38 +0000
Received: from mailhost3.vmware.com (mailhost3.vmware.com [10.16.27.45])	by smtp-outbound-2.vmware.com (Postfix) with ESMTP id AA15D26002;	Thu, 20 May 2010 11:02:37 -0700 (PDT)
Received: from msnyder-server.eng.vmware.com (promd-2s-dhcp138.eng.vmware.com [10.20.124.138])	by mailhost3.vmware.com (Postfix) with ESMTP id A0CE0CD903;	Thu, 20 May 2010 11:02:37 -0700 (PDT)
Message-ID: <4BF5793D.10305@vmware.com>
Date: Thu, 20 May 2010 18:04:00 -0000
From: Michael Snyder <msnyder@vmware.com>
User-Agent: Thunderbird 2.0.0.22 (X11/20090609)
MIME-Version: 1.0
To: Joel Brobecker <brobecker@adacore.com>
CC: "gdb-patches@sourceware.org" <gdb-patches@sourceware.org>
Subject: Re: [rfa] gdb.base/volatile.exp / varargs.exp: replace send_gdb with gdb_test
References: <4BF4497E.9040209@vmware.com> <20100520155010.GA3019@adacore.com>
In-Reply-To: <20100520155010.GA3019@adacore.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
X-IsSubscribed: yes
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2010-05/txt/msg00429.txt.bz2

Joel Brobecker wrote:
> For the record, Michael and I were discussing privately by email,
> and one of the things I wrote was that he should feel free to commit
> if he feels confident about his patches.  Since this can be relatively
> mechanical, this should be relatively safe, and we can deal with
> adjustments using followup patches...
> 
>> 2010-05-19  Michael Snyder  <msnyder@vmware.com>
>>
>> 	* gdb.base/varargs.exp: Replace send_gdb with gdb_test.
>> 	* gdb.base/volatile.exp: Replace send_gdb with gdb_test.
> 
> Some questions/suggestions...
> 
>> -send_gdb "set print sevenbit-strings\n" ; gdb_expect -re "$gdb_prompt $"
>> -send_gdb "set print address off\n" ; gdb_expect -re "$gdb_prompt $"
>> -send_gdb "set width 0\n" ; gdb_expect -re "$gdb_prompt $"
>> +gdb_test "set print sevenbit-strings" "" \
>> +    "set print sevenbit-strings; ${testfile}"
>> +gdb_test "set print address off" "" \
>> +    "set print address off; ${testfile}"
>> +gdb_test "set width 0" "" \
>> +    "set width 0; ${testfile}"
> 
> Just wondering why you added the "testfile" at the end of the test
> description?

I copied it from an existing test.  My guess is that it
uniquifies the output, which otherwise would be identical
for a bunch of tests.

 > It does not seem to serve any purpose, and so yo should
> be able to simplify the above using:
> 
>> +gdb_test "set print sevenbit-strings" ""
>> +gdb_test "set print address off" ""
>> +gdb_test "set width 0" ""

Checking....  it seems that we have instances of at least four
different styles for these three specific statements.  I will
try to homogenize them.