From: Joel Brobecker <brobecker@adacore.com>
To: msnyder@vmware.com
Cc: gdb-patches@sourceware.org, pedro@codesourcery.com
Subject: Re: [rfa] gdb.base/volatile.exp / varargs.exp: replace send_gdb with gdb_test
Date: Thu, 20 May 2010 17:09:00 -0000 [thread overview]
Message-ID: <20100520170639.GC3019@adacore.com> (raw)
In-Reply-To: <201005201746.48113.pedro@codesourcery.com>
> > I think we should - it's something that is so common, and the
> > gdb.reverse section alone is littered with FIXMEs because of
> > this issue.
>
> Yeah, I pointed this out before in that context, and also pointed
> out in that context that for "set foo", we could try "show foo", and
> confirm that what we tried to set actually was set. Similarly
> for any test that should produce no output and that has a
> corresponding "state getter".
Makes total sense to me. It might be unfair to put that on Michael's
shoulders for that patch, but if he's up for it, maybe as a followup
patch...
> > gdb_test_no_output?
>
> Sounds good.
Michael: Are you up for implementing that function? It should be in
testsuite/lib/gdb.exp, and implemented using the code that Pedro
provided (minus the regexp part between the anchor and the \n\r).
Otherwise, I'll try to work on it later this afternoon for you.
--
Joel
next prev parent reply other threads:[~2010-05-20 17:06 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-19 20:54 Michael Snyder
2010-05-20 16:13 ` Joel Brobecker
2010-05-20 16:31 ` Pedro Alves
2010-05-20 16:42 ` Joel Brobecker
2010-05-20 16:47 ` Pedro Alves
2010-05-20 17:09 ` Joel Brobecker [this message]
2010-05-20 17:57 ` Pedro Alves
2010-05-20 18:08 ` Michael Snyder
2010-05-20 19:45 ` [commit/testsuite] lib/gdb.exp: New gdb_test_no_output function Joel Brobecker
2010-05-20 18:04 ` [rfa] gdb.base/volatile.exp / varargs.exp: replace send_gdb with gdb_test Michael Snyder
2010-05-20 18:40 ` Joel Brobecker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100520170639.GC3019@adacore.com \
--to=brobecker@adacore.com \
--cc=gdb-patches@sourceware.org \
--cc=msnyder@vmware.com \
--cc=pedro@codesourcery.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox