From: Joel Brobecker <brobecker@adacore.com>
To: Michael Snyder <msnyder@vmware.com>
Cc: "gdb-patches@sourceware.org" <gdb-patches@sourceware.org>
Subject: Re: [rfa] gdb.base/volatile.exp / varargs.exp: replace send_gdb with gdb_test
Date: Thu, 20 May 2010 18:40:00 -0000 [thread overview]
Message-ID: <20100520182355.GD3019@adacore.com> (raw)
In-Reply-To: <4BF5793D.10305@vmware.com>
> >Just wondering why you added the "testfile" at the end of the test
> >description?
>
> I copied it from an existing test. My guess is that it
> uniquifies the output, which otherwise would be identical
> for a bunch of tests.
You mean, from another testcase? The test description is the combination
of the testcase name (.exp file) and test name (in our case, the command).
I think I double-checked in this specific testcase that the command was
used only once, so the uniqueness should be guaranteed.
> >>+gdb_test "set print sevenbit-strings" ""
> >>+gdb_test "set print address off" ""
> >>+gdb_test "set width 0" ""
>
> Checking.... it seems that we have instances of at least four
> different styles for these three specific statements. I will
> try to homogenize them.
Just a thought, because I haven't really looked at what the "four
different styles" are, but I agree with Pedro when he says that
we should have separate patches for each step. If the homogenization
is not a mechanical step, perhaps it would be a good candidate for
a followup test?
--
Joel
prev parent reply other threads:[~2010-05-20 18:24 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-19 20:54 Michael Snyder
2010-05-20 16:13 ` Joel Brobecker
2010-05-20 16:31 ` Pedro Alves
2010-05-20 16:42 ` Joel Brobecker
2010-05-20 16:47 ` Pedro Alves
2010-05-20 17:09 ` Joel Brobecker
2010-05-20 17:57 ` Pedro Alves
2010-05-20 18:08 ` Michael Snyder
2010-05-20 19:45 ` [commit/testsuite] lib/gdb.exp: New gdb_test_no_output function Joel Brobecker
2010-05-20 18:04 ` [rfa] gdb.base/volatile.exp / varargs.exp: replace send_gdb with gdb_test Michael Snyder
2010-05-20 18:40 ` Joel Brobecker [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100520182355.GD3019@adacore.com \
--to=brobecker@adacore.com \
--cc=gdb-patches@sourceware.org \
--cc=msnyder@vmware.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox