From: Stan Shebs <stan@codesourcery.com>
To: Joel Brobecker <brobecker@adacore.com>
Cc: Pierre Muller <pierre.muller@ics-cnrs.unistra.fr>,
'Pedro Alves' <pedro@codesourcery.com>,
gdb-patches@sourceware.org
Subject: Re: [ARI] Remove all editCase warnings
Date: Wed, 05 May 2010 17:15:00 -0000 [thread overview]
Message-ID: <4BE1A7BA.9000803@codesourcery.com> (raw)
In-Reply-To: <20100505165529.GO2768@adacore.com>
Joel Brobecker wrote:
>> static void
>> -ada_remove_Xbn_suffix (const char *encoded, int *len)
>> +ada_remove_Xbn_suffix ( /* ARI: editCase function */
>> + const char *encoded, int *len)
>>
>
> I would rather have:
>
> ada_remove_Xbn_suffix /* ARI: editCase function */
> (const char *encoded, int *len)
>
I frequently grep for "foo (", so this would cause the function to be
overlooked. But, fewer grep results means less work when changing the
code... :-)
Stan
next prev parent reply other threads:[~2010-05-05 17:15 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-04 23:25 Pierre Muller
2010-05-04 23:32 ` Stan Shebs
2010-05-04 23:44 ` Pedro Alves
2010-05-04 23:51 ` Michael Snyder
2010-05-05 9:03 ` Pierre Muller
2010-05-05 14:54 ` Joel Brobecker
2010-05-05 15:11 ` Pedro Alves
2010-05-05 16:09 ` Pierre Muller
2010-05-05 16:55 ` Joel Brobecker
2010-05-05 17:15 ` Stan Shebs [this message]
2010-05-05 21:03 ` Pierre Muller
2010-05-06 18:10 ` Joel Brobecker
2010-05-05 18:34 ` Daniel Jacobowitz
2010-05-05 18:37 ` Joel Brobecker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4BE1A7BA.9000803@codesourcery.com \
--to=stan@codesourcery.com \
--cc=brobecker@adacore.com \
--cc=gdb-patches@sourceware.org \
--cc=pedro@codesourcery.com \
--cc=pierre.muller@ics-cnrs.unistra.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox