From: Michael Snyder <msnyder@vmware.com>
To: Pedro Alves <pedro@codesourcery.com>
Cc: "gdb-patches@sourceware.org" <gdb-patches@sourceware.org>,
Pierre Muller <pierre.muller@ics-cnrs.unistra.fr>
Subject: Re: [ARI] Remove all editCase warnings
Date: Tue, 04 May 2010 23:51:00 -0000 [thread overview]
Message-ID: <4BE0B30D.8050009@vmware.com> (raw)
In-Reply-To: <201005050044.28991.pedro@codesourcery.com>
Pedro Alves wrote:
> On Wednesday 05 May 2010 00:25:48, Pierre Muller wrote:
>> ARI: Fix editCase.
>
>> * remote.c (set_remote_protocol_Z_packet_cmd): Rename to...
>> (set_remote_protocol_z_packet_cmd): ...this.
>> (show_remote_protocol_Z_packet_cmd): Rename to...
>> (show_remote_protocol_z_packet_cmd): ...this.
>> (store_register_using_P): Rename to...
>> (store_register_using_p): ...this.
>> (store_register_using_G): Rename to...
>> (store_register_using_g): ...this.
>> (remote_store_registers): Adapt to name changes above.
>> (watchpoint_to_Z_packet): Rename to...
>> (watchpoint_to_z_packet): ...this.
>
> I'd rather not. Z, z, P, G, g, are all distinct packets, uppercase
> having the opposite effect of lowercase. Example, you really store
> with G, not g, which is for fetches (note the `fetch_registers_using_g'
> function).
I agree with Pedro and Stan.
next prev parent reply other threads:[~2010-05-04 23:51 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-04 23:25 Pierre Muller
2010-05-04 23:32 ` Stan Shebs
2010-05-04 23:44 ` Pedro Alves
2010-05-04 23:51 ` Michael Snyder [this message]
2010-05-05 9:03 ` Pierre Muller
2010-05-05 14:54 ` Joel Brobecker
2010-05-05 15:11 ` Pedro Alves
2010-05-05 16:09 ` Pierre Muller
2010-05-05 16:55 ` Joel Brobecker
2010-05-05 17:15 ` Stan Shebs
2010-05-05 21:03 ` Pierre Muller
2010-05-06 18:10 ` Joel Brobecker
2010-05-05 18:34 ` Daniel Jacobowitz
2010-05-05 18:37 ` Joel Brobecker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4BE0B30D.8050009@vmware.com \
--to=msnyder@vmware.com \
--cc=gdb-patches@sourceware.org \
--cc=pedro@codesourcery.com \
--cc=pierre.muller@ics-cnrs.unistra.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox