From: Pedro Alves <pedro@codesourcery.com>
To: gdb-patches@sourceware.org
Cc: "Pierre Muller" <pierre.muller@ics-cnrs.unistra.fr>
Subject: Re: [ARI] Remove all editCase warnings
Date: Tue, 04 May 2010 23:44:00 -0000 [thread overview]
Message-ID: <201005050044.28991.pedro@codesourcery.com> (raw)
In-Reply-To: <005b01caebe1$2183b890$648b29b0$@muller@ics-cnrs.unistra.fr>
On Wednesday 05 May 2010 00:25:48, Pierre Muller wrote:
> ARI: Fix editCase.
> * ada-lang.c (ada_remove_Xbn_suffix): Rename to...
> (ada_remove_xbn_suffix): ...this.
The function really removes "X", not "x".
> * addrmap.c (splay_compare_CORE_ADDR_ptr): Rename to...
> (splay_compare_core_addr_ptr): ...this.
errr. Don't care.
> * hppa-tdep.c (hppa_extract_5R_store): Rename to...
> (hppa_extract_r_store): ...this.
I don't know this code at all, but I wouldn't be suprised
if the 5r vs 5R had meaning to someone knowing hppa. (there's
a "5r" variant of this function above the "5R" variant.) E.g.,:
int hppa_extract_5_load (unsigned int);
unsigned hppa_extract_5R_store (unsigned int);
unsigned hppa_extract_5r_store (unsigned int);
> * ia64-tdep.c (slotN_contents): Rename to...
> (slotn_contents): ...this.
> (replace_slotN_contents): Rename to...
> (replace_slotn_contents): ...this.
No comments. But I bet whoever wrote this was well aware
of our coding conventions and still chose an uppercase N.
> * remote.c (set_remote_protocol_Z_packet_cmd): Rename to...
> (set_remote_protocol_z_packet_cmd): ...this.
> (show_remote_protocol_Z_packet_cmd): Rename to...
> (show_remote_protocol_z_packet_cmd): ...this.
> (store_register_using_P): Rename to...
> (store_register_using_p): ...this.
> (store_register_using_G): Rename to...
> (store_register_using_g): ...this.
> (remote_store_registers): Adapt to name changes above.
> (watchpoint_to_Z_packet): Rename to...
> (watchpoint_to_z_packet): ...this.
I'd rather not. Z, z, P, G, g, are all distinct packets, uppercase
having the opposite effect of lowercase. Example, you really store
with G, not g, which is for fetches (note the `fetch_registers_using_g'
function).
> * sol-thread.c (ps_lgetLDT): Add ARI comment for editCase.
> Adapt to name change in procfs.c source.
I'd bet this spelling was the reason for the `procfs_find_LDT_entry'
spelling in procfs.c. ps_lgetLDT is the main caller
of `procfs_find_LDT_entry'.
> * windows-nat.c (_initialize_check_for_gdb_ini): Add ARI
> comment to all windows API replacement functions.
Honestly, I think this rule is one of those that generates
work for not such a great reason. IMO, code review enough catches
all the bad cases before they get to the tree.
--
Pedro Alves
next prev parent reply other threads:[~2010-05-04 23:44 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-04 23:25 Pierre Muller
2010-05-04 23:32 ` Stan Shebs
2010-05-04 23:44 ` Pedro Alves [this message]
2010-05-04 23:51 ` Michael Snyder
2010-05-05 9:03 ` Pierre Muller
2010-05-05 14:54 ` Joel Brobecker
2010-05-05 15:11 ` Pedro Alves
2010-05-05 16:09 ` Pierre Muller
2010-05-05 16:55 ` Joel Brobecker
2010-05-05 17:15 ` Stan Shebs
2010-05-05 21:03 ` Pierre Muller
2010-05-06 18:10 ` Joel Brobecker
2010-05-05 18:34 ` Daniel Jacobowitz
2010-05-05 18:37 ` Joel Brobecker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201005050044.28991.pedro@codesourcery.com \
--to=pedro@codesourcery.com \
--cc=gdb-patches@sourceware.org \
--cc=pierre.muller@ics-cnrs.unistra.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox