From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 25223 invoked by alias); 4 May 2010 23:44:40 -0000 Received: (qmail 25215 invoked by uid 22791); 4 May 2010 23:44:40 -0000 X-SWARE-Spam-Status: No, hits=-2.2 required=5.0 tests=AWL,BAYES_00,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mail.codesourcery.com (HELO mail.codesourcery.com) (38.113.113.100) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 04 May 2010 23:44:34 +0000 Received: (qmail 13211 invoked from network); 4 May 2010 23:44:32 -0000 Received: from unknown (HELO orlando.localnet) (pedro@127.0.0.2) by mail.codesourcery.com with ESMTPA; 4 May 2010 23:44:32 -0000 From: Pedro Alves To: gdb-patches@sourceware.org Subject: Re: [ARI] Remove all editCase warnings Date: Tue, 04 May 2010 23:44:00 -0000 User-Agent: KMail/1.12.2 (Linux/2.6.31-20-generic; KDE/4.3.2; x86_64; ; ) Cc: "Pierre Muller" References: <005b01caebe1$2183b890$648b29b0$@muller@ics-cnrs.unistra.fr> In-Reply-To: <005b01caebe1$2183b890$648b29b0$@muller@ics-cnrs.unistra.fr> MIME-Version: 1.0 Content-Type: Text/Plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Message-Id: <201005050044.28991.pedro@codesourcery.com> X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2010-05/txt/msg00083.txt.bz2 On Wednesday 05 May 2010 00:25:48, Pierre Muller wrote: > ARI: Fix editCase. > * ada-lang.c (ada_remove_Xbn_suffix): Rename to... > (ada_remove_xbn_suffix): ...this. The function really removes "X", not "x". > * addrmap.c (splay_compare_CORE_ADDR_ptr): Rename to... > (splay_compare_core_addr_ptr): ...this. errr. Don't care. > * hppa-tdep.c (hppa_extract_5R_store): Rename to... > (hppa_extract_r_store): ...this. I don't know this code at all, but I wouldn't be suprised if the 5r vs 5R had meaning to someone knowing hppa. (there's a "5r" variant of this function above the "5R" variant.) E.g.,: int hppa_extract_5_load (unsigned int); unsigned hppa_extract_5R_store (unsigned int); unsigned hppa_extract_5r_store (unsigned int); > * ia64-tdep.c (slotN_contents): Rename to... > (slotn_contents): ...this. > (replace_slotN_contents): Rename to... > (replace_slotn_contents): ...this. No comments. But I bet whoever wrote this was well aware of our coding conventions and still chose an uppercase N. > * remote.c (set_remote_protocol_Z_packet_cmd): Rename to... > (set_remote_protocol_z_packet_cmd): ...this. > (show_remote_protocol_Z_packet_cmd): Rename to... > (show_remote_protocol_z_packet_cmd): ...this. > (store_register_using_P): Rename to... > (store_register_using_p): ...this. > (store_register_using_G): Rename to... > (store_register_using_g): ...this. > (remote_store_registers): Adapt to name changes above. > (watchpoint_to_Z_packet): Rename to... > (watchpoint_to_z_packet): ...this. I'd rather not. Z, z, P, G, g, are all distinct packets, uppercase having the opposite effect of lowercase. Example, you really store with G, not g, which is for fetches (note the `fetch_registers_using_g' function). > * sol-thread.c (ps_lgetLDT): Add ARI comment for editCase. > Adapt to name change in procfs.c source. I'd bet this spelling was the reason for the `procfs_find_LDT_entry' spelling in procfs.c. ps_lgetLDT is the main caller of `procfs_find_LDT_entry'. > * windows-nat.c (_initialize_check_for_gdb_ini): Add ARI > comment to all windows API replacement functions. Honestly, I think this rule is one of those that generates work for not such a great reason. IMO, code review enough catches all the bad cases before they get to the tree. -- Pedro Alves