From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 30155 invoked by alias); 4 May 2010 23:51:48 -0000 Received: (qmail 30147 invoked by uid 22791); 4 May 2010 23:51:48 -0000 X-SWARE-Spam-Status: No, hits=-2.1 required=5.0 tests=AWL,BAYES_00,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from smtp-outbound-2.vmware.com (HELO smtp-outbound-2.vmware.com) (65.115.85.73) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 04 May 2010 23:51:44 +0000 Received: from mailhost3.vmware.com (mailhost3.vmware.com [10.16.27.45]) by smtp-outbound-2.vmware.com (Postfix) with ESMTP id 906BC32005; Tue, 4 May 2010 16:51:41 -0700 (PDT) Received: from msnyder-server.eng.vmware.com (promd-2s-dhcp138.eng.vmware.com [10.20.124.138]) by mailhost3.vmware.com (Postfix) with ESMTP id 84BFECD91F; Tue, 4 May 2010 16:51:41 -0700 (PDT) Message-ID: <4BE0B30D.8050009@vmware.com> Date: Tue, 04 May 2010 23:51:00 -0000 From: Michael Snyder User-Agent: Thunderbird 2.0.0.22 (X11/20090609) MIME-Version: 1.0 To: Pedro Alves CC: "gdb-patches@sourceware.org" , Pierre Muller Subject: Re: [ARI] Remove all editCase warnings References: <005b01caebe1$2183b890$648b29b0$@muller@ics-cnrs.unistra.fr> <201005050044.28991.pedro@codesourcery.com> In-Reply-To: <201005050044.28991.pedro@codesourcery.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2010-05/txt/msg00084.txt.bz2 Pedro Alves wrote: > On Wednesday 05 May 2010 00:25:48, Pierre Muller wrote: >> ARI: Fix editCase. > >> * remote.c (set_remote_protocol_Z_packet_cmd): Rename to... >> (set_remote_protocol_z_packet_cmd): ...this. >> (show_remote_protocol_Z_packet_cmd): Rename to... >> (show_remote_protocol_z_packet_cmd): ...this. >> (store_register_using_P): Rename to... >> (store_register_using_p): ...this. >> (store_register_using_G): Rename to... >> (store_register_using_g): ...this. >> (remote_store_registers): Adapt to name changes above. >> (watchpoint_to_Z_packet): Rename to... >> (watchpoint_to_z_packet): ...this. > > I'd rather not. Z, z, P, G, g, are all distinct packets, uppercase > having the opposite effect of lowercase. Example, you really store > with G, not g, which is for fetches (note the `fetch_registers_using_g' > function). I agree with Pedro and Stan.