From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-72810-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 15086 invoked by alias); 5 May 2010 17:15:53 -0000
Received: (qmail 15061 invoked by uid 22791); 5 May 2010 17:15:51 -0000
X-SWARE-Spam-Status: No, hits=-2.1 required=5.0	tests=AWL,BAYES_00,T_RP_MATCHES_RCVD
X-Spam-Check-By: sourceware.org
Received: from mail.codesourcery.com (HELO mail.codesourcery.com) (38.113.113.100)    by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 05 May 2010 17:15:46 +0000
Received: (qmail 32118 invoked from network); 5 May 2010 17:15:44 -0000
Received: from unknown (HELO macbook-2.local) (stan@127.0.0.2)  by mail.codesourcery.com with ESMTPA; 5 May 2010 17:15:44 -0000
Message-ID: <4BE1A7BA.9000803@codesourcery.com>
Date: Wed, 05 May 2010 17:15:00 -0000
From: Stan Shebs <stan@codesourcery.com>
User-Agent: Thunderbird 2.0.0.24 (Macintosh/20100228)
MIME-Version: 1.0
To: Joel Brobecker <brobecker@adacore.com>
CC: Pierre Muller <pierre.muller@ics-cnrs.unistra.fr>,  'Pedro Alves' <pedro@codesourcery.com>, gdb-patches@sourceware.org
Subject: Re: [ARI] Remove all editCase warnings
References: <005b01caebe1$2183b890$648b29b0$@muller@ics-cnrs.unistra.fr> <201005050044.28991.pedro@codesourcery.com> <000901caec31$d109e640$731db2c0$@muller@ics-cnrs.unistra.fr> <201005051611.09790.pedro@codesourcery.com> <000001caec6d$59194860$0b4bd920$@muller@ics-cnrs.unistra.fr> <20100505165529.GO2768@adacore.com>
In-Reply-To: <20100505165529.GO2768@adacore.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2010-05/txt/msg00103.txt.bz2

Joel Brobecker wrote:
>>  static void
>> -ada_remove_Xbn_suffix (const char *encoded, int *len)
>> +ada_remove_Xbn_suffix ( /* ARI: editCase function */
>> +		       const char *encoded, int *len)
>>     
>
> I would rather have:
>
> ada_remove_Xbn_suffix /* ARI: editCase function */
>   (const char *encoded, int *len)
>   

I frequently grep for "foo (", so this would cause the function to be 
overlooked.  But, fewer grep results means less work when changing the 
code... :-)

Stan