From: Michael Snyder <msnyder@vmware.com>
To: Pedro Alves <pedro@codesourcery.com>
Cc: Eli Zaretskii <eliz@gnu.org>,
"gdb-patches@sourceware.org" <gdb-patches@sourceware.org>,
"jakob@virtutech.com" <jakob@virtutech.com>,
"glaw@undo-software.com" <glaw@undo-software.com>
Subject: Re: [PATCH] Add 'reverse' capability query to remote protocol (qSupported).
Date: Mon, 07 Sep 2009 22:19:00 -0000 [thread overview]
Message-ID: <4AA586A3.20907@vmware.com> (raw)
In-Reply-To: <200909072229.46597.pedro@codesourcery.com>
Pedro Alves wrote:
> On Sunday 06 September 2009 04:36:22, Michael Snyder wrote:
>> Eli Zaretskii wrote:
>>>> From: Pedro Alves <pedro@codesourcery.com>
>>>> Date: Tue, 1 Sep 2009 16:44:13 +0100
>>>> Cc: Michael Snyder <msnyder@vmware.com>, Jakob Engblom <jakob@virtutech.com>, Greg Law <glaw@undo-software.com>
>>>>
>>>> Your patch also needs docs and NEWS entries, BTW.
>>> And a patch for the manual documenting the new packets, no?
>> New diff incorporating comments and adding docs and NEWS.
>
> What about the i18n comments?
Oof, sorry, forgot. You just mean the two error msgs, right?
See revised diff.
> What about the vCont (the one about not sending vcont
> if requesting a reverse resume) comments?
Are you sure? I guess, like you, I hoped it would eventually
be added. Works fine as it is, it probes and fails, but if
you want it, ok... added below.
I have one final question to raise.
You may notice (though nobody has commented), that I made the
two new supported-probed-packets (bs and bc) default to "enabled".
This sort of defeats the purpose (if the purpose is that we can
decide whether to run a testsuite on a remote target) -- but I
was just reluctant to default them to "disabled", because it
would mean that anybody with a deployed target that doesn't yet
support the new "qSupported" probe would have to make his users
enable them by hand.
(why I cc:ed Jakob and Greg.)
So now that I've mentioned it, what do you think?
Enabled, or disabled by default?
next prev parent reply other threads:[~2009-09-07 22:19 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-08-31 20:02 Michael Snyder
2009-09-01 2:44 ` Hui Zhu
2009-09-01 4:02 ` Michael Snyder
2009-09-01 4:44 ` Hui Zhu
2009-09-01 15:52 ` Pedro Alves
2009-09-01 15:44 ` Pedro Alves
2009-09-01 17:07 ` Eli Zaretskii
2009-09-06 3:37 ` Michael Snyder
2009-09-06 17:05 ` Eli Zaretskii
2009-09-07 21:29 ` Pedro Alves
2009-09-07 22:19 ` Michael Snyder [this message]
2009-09-07 22:20 ` Michael Snyder
2009-09-07 22:33 ` Pedro Alves
2009-09-08 7:40 ` Greg Law
2009-09-09 10:45 ` Jakob Engblom
2009-09-10 21:03 ` Michael Snyder
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4AA586A3.20907@vmware.com \
--to=msnyder@vmware.com \
--cc=eliz@gnu.org \
--cc=gdb-patches@sourceware.org \
--cc=glaw@undo-software.com \
--cc=jakob@virtutech.com \
--cc=pedro@codesourcery.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox