From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 31974 invoked by alias); 7 Sep 2009 22:19:43 -0000 Received: (qmail 31965 invoked by uid 22791); 7 Sep 2009 22:19:42 -0000 X-SWARE-Spam-Status: No, hits=-2.0 required=5.0 tests=AWL,BAYES_00,J_CHICKENPOX_22,SARE_SUB_OBFU_Q1 X-Spam-Check-By: sourceware.org Received: from smtp-outbound-1.vmware.com (HELO smtp-outbound-1.vmware.com) (65.115.85.69) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 07 Sep 2009 22:19:34 +0000 Received: from mailhost4.vmware.com (mailhost4.vmware.com [10.16.67.124]) by smtp-outbound-1.vmware.com (Postfix) with ESMTP id BA7413B000; Mon, 7 Sep 2009 15:19:32 -0700 (PDT) Received: from [10.20.94.141] (msnyder-server.eng.vmware.com [10.20.94.141]) by mailhost4.vmware.com (Postfix) with ESMTP id ADDECC9B93; Mon, 7 Sep 2009 15:19:32 -0700 (PDT) Message-ID: <4AA586A3.20907@vmware.com> Date: Mon, 07 Sep 2009 22:19:00 -0000 From: Michael Snyder User-Agent: Thunderbird 1.5.0.12 (X11/20080411) MIME-Version: 1.0 To: Pedro Alves CC: Eli Zaretskii , "gdb-patches@sourceware.org" , "jakob@virtutech.com" , "glaw@undo-software.com" Subject: Re: [PATCH] Add 'reverse' capability query to remote protocol (qSupported). References: <4A9C2AD3.5070904@vmware.com> <837hwia96c.fsf@gnu.org> <4AA32E36.1020709@vmware.com> <200909072229.46597.pedro@codesourcery.com> In-Reply-To: <200909072229.46597.pedro@codesourcery.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2009-09/txt/msg00173.txt.bz2 Pedro Alves wrote: > On Sunday 06 September 2009 04:36:22, Michael Snyder wrote: >> Eli Zaretskii wrote: >>>> From: Pedro Alves >>>> Date: Tue, 1 Sep 2009 16:44:13 +0100 >>>> Cc: Michael Snyder , Jakob Engblom , Greg Law >>>> >>>> Your patch also needs docs and NEWS entries, BTW. >>> And a patch for the manual documenting the new packets, no? >> New diff incorporating comments and adding docs and NEWS. > > What about the i18n comments? Oof, sorry, forgot. You just mean the two error msgs, right? See revised diff. > What about the vCont (the one about not sending vcont > if requesting a reverse resume) comments? Are you sure? I guess, like you, I hoped it would eventually be added. Works fine as it is, it probes and fails, but if you want it, ok... added below. I have one final question to raise. You may notice (though nobody has commented), that I made the two new supported-probed-packets (bs and bc) default to "enabled". This sort of defeats the purpose (if the purpose is that we can decide whether to run a testsuite on a remote target) -- but I was just reluctant to default them to "disabled", because it would mean that anybody with a deployed target that doesn't yet support the new "qSupported" probe would have to make his users enable them by hand. (why I cc:ed Jakob and Greg.) So now that I've mentioned it, what do you think? Enabled, or disabled by default?