From: Pedro Alves <pedro@codesourcery.com>
To: Michael Snyder <msnyder@vmware.com>
Cc: Hui Zhu <teawater@gmail.com>,
"gdb-patches@sourceware.org" <gdb-patches@sourceware.org>,
Jakob Engblom <jakob@virtutech.com>,
Greg Law <glaw@undo-software.com>
Subject: Re: [PATCH] Add 'reverse' capability query to remote protocol (qSupported).
Date: Tue, 01 Sep 2009 15:52:00 -0000 [thread overview]
Message-ID: <200909011652.29388.pedro@codesourcery.com> (raw)
In-Reply-To: <4A9C9CD2.7030207@vmware.com>
[replying to the updated patch itself]
> +
> + if (step &&
> + remote_protocol_packets[PACKET_bs].support == PACKET_DISABLE)
> + error ("Remote reverse-step not supported.");
> + if (!step &&
> + remote_protocol_packets[PACKET_bc].support == PACKET_DISABLE)
> + error ("Remote reverse-continue not supported.");
> +
'&&' at beginning of new line, not at end of previous line. The
error strings need wrapping in _() for i18n.
Don't forget docs and NEWS. :-)
--
Pedro Alves
next prev parent reply other threads:[~2009-09-01 15:52 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-08-31 20:02 Michael Snyder
2009-09-01 2:44 ` Hui Zhu
2009-09-01 4:02 ` Michael Snyder
2009-09-01 4:44 ` Hui Zhu
2009-09-01 15:52 ` Pedro Alves [this message]
2009-09-01 15:44 ` Pedro Alves
2009-09-01 17:07 ` Eli Zaretskii
2009-09-06 3:37 ` Michael Snyder
2009-09-06 17:05 ` Eli Zaretskii
2009-09-07 21:29 ` Pedro Alves
2009-09-07 22:19 ` Michael Snyder
2009-09-07 22:20 ` Michael Snyder
2009-09-07 22:33 ` Pedro Alves
2009-09-08 7:40 ` Greg Law
2009-09-09 10:45 ` Jakob Engblom
2009-09-10 21:03 ` Michael Snyder
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200909011652.29388.pedro@codesourcery.com \
--to=pedro@codesourcery.com \
--cc=gdb-patches@sourceware.org \
--cc=glaw@undo-software.com \
--cc=jakob@virtutech.com \
--cc=msnyder@vmware.com \
--cc=teawater@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox