From: Pedro Alves <pedro@codesourcery.com>
To: gdb-patches@sourceware.org
Cc: Michael Snyder <msnyder@vmware.com>,
Jakob Engblom <jakob@virtutech.com>,
Greg Law <glaw@undo-software.com>
Subject: Re: [PATCH] Add 'reverse' capability query to remote protocol (qSupported).
Date: Tue, 01 Sep 2009 15:44:00 -0000 [thread overview]
Message-ID: <200909011644.14035.pedro@codesourcery.com> (raw)
In-Reply-To: <4A9C2AD3.5070904@vmware.com>
On Monday 31 August 2009 20:56:03, Michael Snyder wrote:
> Following discussion, this patch adds feature capability handling
> (enable, disable, and automatic "qSupported" query) for the reverse
> execution packets "bs" (backward step) and "bc" (backward continue
> in the gdb remote protocol.
>
> Cc:ing Jakob and Greg, whose remote targets may be affected.
> What you guys will want to do is have your remote targets
> recognize the "qSupported" query from gdb, and respond with:
>
> ReverseContinue+;ReverseStep+
>
> This will tell gdb that your targets support those two commands.
>
> Otherwise, they default to "disabled", and a user would need
> to enable them with these commands (which might be added to a
> .gdbinit file):
>
> set remote reverse-continue on
> set remote reverse-step on
>
> Pedro, does this look like what you expected?
Yeah, something like that. Thanks! Hui already mentioned
target_can_execute_reverse (thanks!). Initialy I was actually
thinking of the target reporting a single "CanReverse" feature, not a
feature for each packet. I mean, the core of gdb only
knows about target_can_execute_reverse() your idea works for me too,
if it makes sense to you.
While you're at it, how about making remote_resume skip calling
remote_vcont_resume if GDB is requesting a reverse resume?
(I was hoping that someday we'd add reverse support to
vCont packets, so gdb could make use of
say: "vCont?" -> "vCont;c;s;C;S;rs;rc". Something like vCont
will be necessary if gdb is to control (non-transparently) simultaneous
multiple sort-of-independently reversible devices like Jakob
seems to indicate his target can.)
Your patch also needs docs and NEWS entries, BTW.
--
Pedro Alves
next prev parent reply other threads:[~2009-09-01 15:44 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-08-31 20:02 Michael Snyder
2009-09-01 2:44 ` Hui Zhu
2009-09-01 4:02 ` Michael Snyder
2009-09-01 4:44 ` Hui Zhu
2009-09-01 15:52 ` Pedro Alves
2009-09-01 15:44 ` Pedro Alves [this message]
2009-09-01 17:07 ` Eli Zaretskii
2009-09-06 3:37 ` Michael Snyder
2009-09-06 17:05 ` Eli Zaretskii
2009-09-07 21:29 ` Pedro Alves
2009-09-07 22:19 ` Michael Snyder
2009-09-07 22:20 ` Michael Snyder
2009-09-07 22:33 ` Pedro Alves
2009-09-08 7:40 ` Greg Law
2009-09-09 10:45 ` Jakob Engblom
2009-09-10 21:03 ` Michael Snyder
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200909011644.14035.pedro@codesourcery.com \
--to=pedro@codesourcery.com \
--cc=gdb-patches@sourceware.org \
--cc=glaw@undo-software.com \
--cc=jakob@virtutech.com \
--cc=msnyder@vmware.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox