From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-66425-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 11991 invoked by alias); 1 Sep 2009 15:52:37 -0000
Received: (qmail 11981 invoked by uid 22791); 1 Sep 2009 15:52:36 -0000
X-SWARE-Spam-Status: No, hits=-2.2 required=5.0 	tests=AWL,BAYES_00,SARE_SUB_OBFU_Q1,SPF_PASS
X-Spam-Check-By: sourceware.org
Received: from mail.codesourcery.com (HELO mail.codesourcery.com) (65.74.133.4)     by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 01 Sep 2009 15:52:32 +0000
Received: (qmail 26202 invoked from network); 1 Sep 2009 15:52:30 -0000
Received: from unknown (HELO orlando) (pedro@127.0.0.2)   by mail.codesourcery.com with ESMTPA; 1 Sep 2009 15:52:30 -0000
From: Pedro Alves <pedro@codesourcery.com>
To: Michael Snyder <msnyder@vmware.com>
Subject: Re: [PATCH] Add 'reverse' capability query to remote protocol  =?iso-8859-1?q?=09?=(qSupported).
Date: Tue, 01 Sep 2009 15:52:00 -0000
User-Agent: KMail/1.9.10
Cc: Hui Zhu <teawater@gmail.com>,  "gdb-patches@sourceware.org" <gdb-patches@sourceware.org>,  Jakob Engblom <jakob@virtutech.com>,  Greg Law <glaw@undo-software.com>
References: <4A9C2AD3.5070904@vmware.com> <daef60380908311943u447649edy3ed031b43adaea27@mail.gmail.com> <4A9C9CD2.7030207@vmware.com>
In-Reply-To: <4A9C9CD2.7030207@vmware.com>
MIME-Version: 1.0
Content-Type: text/plain;   charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable
Content-Disposition: inline
Message-Id: <200909011652.29388.pedro@codesourcery.com>
X-IsSubscribed: yes
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2009-09/txt/msg00020.txt.bz2

[replying to the updated patch itself]

> +
> + =A0 =A0 =A0if (step &&
> +=A0=A0=A0=A0=A0=A0=A0 =A0remote_protocol_packets[PACKET_bs].support =3D=
=3D PACKET_DISABLE)
> +=A0=A0=A0=A0=A0=A0=A0error ("Remote reverse-step not supported.");
> + =A0 =A0 =A0if (!step &&
> +=A0=A0=A0=A0=A0=A0=A0 =A0remote_protocol_packets[PACKET_bc].support =3D=
=3D PACKET_DISABLE)
> +=A0=A0=A0=A0=A0=A0=A0error ("Remote reverse-continue not supported.");
> +

'&&' at beginning of new line, not at end of previous line.  The
error strings need wrapping in _() for i18n.

Don't forget docs and NEWS.  :-)

--=20
Pedro Alves