[OB] Fix syntax error in record_resume

[OB] Fix syntax error in record_resume

[Hui Zhu]

Checked in under the obvious rule.

Thanks,
Hui

2009-09-01  Hui Zhu  <teawater@gmail.com>

	* record.c (record_resume): Change "siggnal" to "signal".

===================================================================
RCS file: /cvs/src/src/gdb/record.c,v
retrieving revision 1.14
retrieving revision 1.15
diff -u -r1.14 -r1.15
--- src/gdb/record.c	2009/09/01 03:32:49	1.14
+++ src/gdb/record.c	2009/09/01 11:41:41	1.15
@@ -518,7 +518,7 @@

 static void
 record_resume (struct target_ops *ops, ptid_t ptid, int step,
-               enum target_signal siggnal)
+               enum target_signal signal)
 {
   record_resume_step = step;

@@ -534,7 +534,7 @@
           return;
         }
       record_beneath_to_resume (record_beneath_to_resume_ops, ptid, 1,
-                                siggnal);
+                                signal);
     }
 }

Re: [OB] Fix syntax error in record_resume

[Stan Shebs]

Hui Zhu wrote:
> 	* record.c (record_resume): Change "siggnal" to "signal".
>   
FYI, a number of places in the code use "siggnal" for the variable name, 
or some other name that is not "signal".  Once upon a time some hosts 
did nasty macro tricks with "signal" in their system headers, so it was 
better for portability to use some other string.  I don't know if this 
is still an issue though.

Stan

Re: [OB] Fix syntax error in record_resume

[Michael Snyder]

Stan Shebs wrote:
> Hui Zhu wrote:
>> 	* record.c (record_resume): Change "siggnal" to "signal".
>>   
> FYI, a number of places in the code use "siggnal" for the variable name, 
> or some other name that is not "signal".  Once upon a time some hosts 
> did nasty macro tricks with "signal" in their system headers, so it was 
> better for portability to use some other string.  I don't know if this 
> is still an issue though.

I always thought that the name "siggnal" started with a global
variable in gdb, and then just propagated (the way it's trying
to do now).   ;-)

Re: [OB] Fix syntax error in record_resume

[Hui Zhu]

Sorry I make a big mistake.  I will change it back at once.

Thanks for remind me, Stan and Michael.  Thanks a lot.

Hui

On Wed, Sep 2, 2009 at 03:20, Michael Snyder<msnyder@vmware.com> wrote:
> Stan Shebs wrote:
>>
>> Hui Zhu wrote:
>>>
>>>        * record.c (record_resume): Change "siggnal" to "signal".
>>>
>>
>> FYI, a number of places in the code use "siggnal" for the variable name,
>> or some other name that is not "signal".  Once upon a time some hosts did
>> nasty macro tricks with "signal" in their system headers, so it was better
>> for portability to use some other string.  I don't know if this is still an
>> issue though.
>
> I always thought that the name "siggnal" started with a global
> variable in gdb, and then just propagated (the way it's trying
> to do now).   ;-)
>

Re: [OB] Fix syntax error in record_resume

[Hui Zhu]

Checked in.

Hui

2009-09-02  Hui Zhu  <teawater@gmail.com>

	* record.c (record_resume): Change "signal" to "siggnal".

===================================================================
RCS file: /cvs/src/src/gdb/record.c,v
retrieving revision 1.15
retrieving revision 1.16
diff -u -r1.15 -r1.16
--- src/gdb/record.c	2009/09/01 11:41:41	1.15
+++ src/gdb/record.c	2009/09/02 01:31:09	1.16
@@ -518,7 +518,7 @@

 static void
 record_resume (struct target_ops *ops, ptid_t ptid, int step,
-               enum target_signal signal)
+               enum target_signal siggnal)
 {
   record_resume_step = step;

@@ -534,7 +534,7 @@
           return;
         }
       record_beneath_to_resume (record_beneath_to_resume_ops, ptid, 1,
-                                signal);
+                                siggnal);
     }
 }


On Wed, Sep 2, 2009 at 09:27, Hui Zhu<teawater@gmail.com> wrote:
> Sorry I make a big mistake.  I will change it back at once.
>
> Thanks for remind me, Stan and Michael.  Thanks a lot.
>
> Hui
>
> On Wed, Sep 2, 2009 at 03:20, Michael Snyder<msnyder@vmware.com> wrote:
>> Stan Shebs wrote:
>>>
>>> Hui Zhu wrote:
>>>>
>>>>        * record.c (record_resume): Change "siggnal" to "signal".
>>>>
>>>
>>> FYI, a number of places in the code use "siggnal" for the variable name,
>>> or some other name that is not "signal".  Once upon a time some hosts did
>>> nasty macro tricks with "signal" in their system headers, so it was better
>>> for portability to use some other string.  I don't know if this is still an
>>> issue though.
>>
>> I always thought that the name "siggnal" started with a global
>> variable in gdb, and then just propagated (the way it's trying
>> to do now).   ;-)
>>
>