From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-66454-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 23770 invoked by alias); 2 Sep 2009 01:33:22 -0000
Received: (qmail 23761 invoked by uid 22791); 2 Sep 2009 01:33:22 -0000
X-SWARE-Spam-Status: No, hits=-1.7 required=5.0 	tests=AWL,BAYES_00,SARE_MSGID_LONG40,SPF_PASS
X-Spam-Check-By: sourceware.org
Received: from mail-pz0-f195.google.com (HELO mail-pz0-f195.google.com) (209.85.222.195)     by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 02 Sep 2009 01:33:16 +0000
Received: by pzk33 with SMTP id 33so412300pzk.23         for <gdb-patches@sourceware.org>; Tue, 01 Sep 2009 18:33:15 -0700 (PDT)
MIME-Version: 1.0
Received: by 10.143.131.6 with SMTP id i6mr117481wfn.338.1251855195178; Tue,  	01 Sep 2009 18:33:15 -0700 (PDT)
In-Reply-To: <daef60380909011827g7a94d47cm883d30e7491e465a@mail.gmail.com>
References: <daef60380909010454k411d62f2pea6f911b5664778d@mail.gmail.com>  	<4A9D7354.5010207@codesourcery.com> <4A9D7413.5020707@vmware.com>  	<daef60380909011827g7a94d47cm883d30e7491e465a@mail.gmail.com>
From: Hui Zhu <teawater@gmail.com>
Date: Wed, 02 Sep 2009 01:33:00 -0000
Message-ID: <daef60380909011832j4b64ae64w53bce99828836bb2@mail.gmail.com>
Subject: Re: [OB] Fix syntax error in record_resume
To: Michael Snyder <msnyder@vmware.com>, Stan Shebs <stan@codesourcery.com>
Cc: gdb-patches ml <gdb-patches@sourceware.org>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: quoted-printable
X-IsSubscribed: yes
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2009-09/txt/msg00049.txt.bz2

Checked in.

Hui

2009-09-02  Hui Zhu  <teawater@gmail.com>

	* record.c (record_resume): Change "signal" to "siggnal".

=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
RCS file: /cvs/src/src/gdb/record.c,v
retrieving revision 1.15
retrieving revision 1.16
diff -u -r1.15 -r1.16
--- src/gdb/record.c	2009/09/01 11:41:41	1.15
+++ src/gdb/record.c	2009/09/02 01:31:09	1.16
@@ -518,7 +518,7 @@

 static void
 record_resume (struct target_ops *ops, ptid_t ptid, int step,
-               enum target_signal signal)
+               enum target_signal siggnal)
 {
   record_resume_step =3D step;

@@ -534,7 +534,7 @@
           return;
         }
       record_beneath_to_resume (record_beneath_to_resume_ops, ptid, 1,
-                                signal);
+                                siggnal);
     }
 }


On Wed, Sep 2, 2009 at 09:27, Hui Zhu<teawater@gmail.com> wrote:
> Sorry I make a big mistake. =A0I will change it back at once.
>
> Thanks for remind me, Stan and Michael. =A0Thanks a lot.
>
> Hui
>
> On Wed, Sep 2, 2009 at 03:20, Michael Snyder<msnyder@vmware.com> wrote:
>> Stan Shebs wrote:
>>>
>>> Hui Zhu wrote:
>>>>
>>>> =A0 =A0 =A0 =A0* record.c (record_resume): Change "siggnal" to "signal=
".
>>>>
>>>
>>> FYI, a number of places in the code use "siggnal" for the variable name,
>>> or some other name that is not "signal". =A0Once upon a time some hosts=
 did
>>> nasty macro tricks with "signal" in their system headers, so it was bet=
ter
>>> for portability to use some other string. =A0I don't know if this is st=
ill an
>>> issue though.
>>
>> I always thought that the name "siggnal" started with a global
>> variable in gdb, and then just propagated (the way it's trying
>> to do now). =A0 ;-)
>>
>