From: Hui Zhu <teawater@gmail.com>
To: Michael Snyder <msnyder@vmware.com>, Stan Shebs <stan@codesourcery.com>
Cc: gdb-patches ml <gdb-patches@sourceware.org>
Subject: Re: [OB] Fix syntax error in record_resume
Date: Wed, 02 Sep 2009 01:33:00 -0000 [thread overview]
Message-ID: <daef60380909011832j4b64ae64w53bce99828836bb2@mail.gmail.com> (raw)
In-Reply-To: <daef60380909011827g7a94d47cm883d30e7491e465a@mail.gmail.com>
Checked in.
Hui
2009-09-02 Hui Zhu <teawater@gmail.com>
* record.c (record_resume): Change "signal" to "siggnal".
===================================================================
RCS file: /cvs/src/src/gdb/record.c,v
retrieving revision 1.15
retrieving revision 1.16
diff -u -r1.15 -r1.16
--- src/gdb/record.c 2009/09/01 11:41:41 1.15
+++ src/gdb/record.c 2009/09/02 01:31:09 1.16
@@ -518,7 +518,7 @@
static void
record_resume (struct target_ops *ops, ptid_t ptid, int step,
- enum target_signal signal)
+ enum target_signal siggnal)
{
record_resume_step = step;
@@ -534,7 +534,7 @@
return;
}
record_beneath_to_resume (record_beneath_to_resume_ops, ptid, 1,
- signal);
+ siggnal);
}
}
On Wed, Sep 2, 2009 at 09:27, Hui Zhu<teawater@gmail.com> wrote:
> Sorry I make a big mistake. I will change it back at once.
>
> Thanks for remind me, Stan and Michael. Thanks a lot.
>
> Hui
>
> On Wed, Sep 2, 2009 at 03:20, Michael Snyder<msnyder@vmware.com> wrote:
>> Stan Shebs wrote:
>>>
>>> Hui Zhu wrote:
>>>>
>>>> * record.c (record_resume): Change "siggnal" to "signal".
>>>>
>>>
>>> FYI, a number of places in the code use "siggnal" for the variable name,
>>> or some other name that is not "signal". Once upon a time some hosts did
>>> nasty macro tricks with "signal" in their system headers, so it was better
>>> for portability to use some other string. I don't know if this is still an
>>> issue though.
>>
>> I always thought that the name "siggnal" started with a global
>> variable in gdb, and then just propagated (the way it's trying
>> to do now). ;-)
>>
>
prev parent reply other threads:[~2009-09-02 1:33 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-09-01 11:54 Hui Zhu
2009-09-01 19:17 ` Stan Shebs
2009-09-01 19:21 ` Michael Snyder
2009-09-02 1:28 ` Hui Zhu
2009-09-02 1:33 ` Hui Zhu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=daef60380909011832j4b64ae64w53bce99828836bb2@mail.gmail.com \
--to=teawater@gmail.com \
--cc=gdb-patches@sourceware.org \
--cc=msnyder@vmware.com \
--cc=stan@codesourcery.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox