Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Michael Snyder <msnyder@vmware.com>
To: Hui Zhu <teawater@gmail.com>
Cc: Mark Kettenis <mark.kettenis@xs4all.nl>,
	  gdb-patches ml <gdb-patches@sourceware.org>
Subject: Re: [RFA/RFC Prec] Add Linux AMD64 process record support second  	version, (instruction set support) 1/3
Date: Mon, 20 Jul 2009 01:39:00 -0000	[thread overview]
Message-ID: <4A63BF8B.4020906@vmware.com> (raw)
In-Reply-To: <daef60380907191016u67d99861oeac6e5b449b512af@mail.gmail.com>

Hi Hui,

I think I discovered a bug in this one.  In 64-bit mode,
the "call immediate" instruction is not correctly logging
the pushed return address.  It's only saving 4 bytes.

Please tell me what you think of this patch to your patch?

Michael

--- i386-tdep.c 2009-07-19 17:51:58.000300000 -0700
+++ tmp/i386-tdep.c     2009-07-19 17:51:51.000907000 -0700
@@ -4563,6 +4563,8 @@ reswitch:

        /* call im */
      case 0xe8:
+      if (ir.regmap[X86_RECORD_R8_REGNUM] && ir.dflag)
+        ir.dflag = 2;
        if (i386_record_push (&ir, 1 << (ir.dflag + 1)))
          return -1;
        break;


  parent reply	other threads:[~2009-07-20  0:57 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-07-07  2:38 Hui Zhu
2009-07-13  0:52 ` Michael Snyder
2009-07-17  8:50   ` Hui Zhu
2009-07-18  1:20     ` Michael Snyder
2009-07-19 17:21       ` Hui Zhu
2009-07-19 21:22         ` Mark Kettenis
2009-07-20  6:14           ` Hui Zhu
2009-07-20  1:39         ` Michael Snyder [this message]
2009-07-20 10:22           ` Hui Zhu
2009-07-20 14:24             ` Hui Zhu
2009-07-25 22:07         ` Michael Snyder
2009-07-27 16:50           ` Hui Zhu
2009-07-25 22:20         ` Michael Snyder
2009-07-28 11:03           ` Hui Zhu
2009-08-03  5:37             ` Hui Zhu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4A63BF8B.4020906@vmware.com \
    --to=msnyder@vmware.com \
    --cc=gdb-patches@sourceware.org \
    --cc=mark.kettenis@xs4all.nl \
    --cc=teawater@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox