From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-65481-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 15967 invoked by alias); 20 Jul 2009 00:57:15 -0000
Received: (qmail 15959 invoked by uid 22791); 20 Jul 2009 00:57:15 -0000
X-SWARE-Spam-Status: No, hits=-2.1 required=5.0 	tests=AWL,BAYES_00,J_CHICKENPOX_25
X-Spam-Check-By: sourceware.org
Received: from smtp-outbound-1.vmware.com (HELO smtp-outbound-1.vmware.com) (65.115.85.69)     by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 20 Jul 2009 00:57:09 +0000
Received: from mailhost4.vmware.com (mailhost4.vmware.com [10.16.67.124]) 	by smtp-outbound-1.vmware.com (Postfix) with ESMTP id CBBCF3000F; 	Sun, 19 Jul 2009 17:57:05 -0700 (PDT)
Received: from [10.20.94.141] (msnyder-server.eng.vmware.com [10.20.94.141]) 	by mailhost4.vmware.com (Postfix) with ESMTP id C1009C9E4D; 	Sun, 19 Jul 2009 17:57:05 -0700 (PDT)
Message-ID: <4A63BF8B.4020906@vmware.com>
Date: Mon, 20 Jul 2009 01:39:00 -0000
From: Michael Snyder <msnyder@vmware.com>
User-Agent: Thunderbird 1.5.0.12 (X11/20080411)
MIME-Version: 1.0
To: Hui Zhu <teawater@gmail.com>
CC: Mark Kettenis <mark.kettenis@xs4all.nl>,   gdb-patches ml <gdb-patches@sourceware.org>
Subject: Re: [RFA/RFC Prec] Add Linux AMD64 process record support second  	version, (instruction set support) 1/3
References: <daef60380907061937n26fb7503yb30a17273c668a85@mail.gmail.com> 	<4A5A810B.7080603@vmware.com> <daef60380907170146u7c1dd6d4yb4e5e99a9add4634@mail.gmail.com> 	<4A610EE8.1090904@vmware.com> <daef60380907191016u67d99861oeac6e5b449b512af@mail.gmail.com>
In-Reply-To: <daef60380907191016u67d99861oeac6e5b449b512af@mail.gmail.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
X-IsSubscribed: yes
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2009-07/txt/msg00460.txt.bz2

Hi Hui,

I think I discovered a bug in this one.  In 64-bit mode,
the "call immediate" instruction is not correctly logging
the pushed return address.  It's only saving 4 bytes.

Please tell me what you think of this patch to your patch?

Michael

--- i386-tdep.c 2009-07-19 17:51:58.000300000 -0700
+++ tmp/i386-tdep.c     2009-07-19 17:51:51.000907000 -0700
@@ -4563,6 +4563,8 @@ reswitch:

        /* call im */
      case 0xe8:
+      if (ir.regmap[X86_RECORD_R8_REGNUM] && ir.dflag)
+        ir.dflag = 2;
        if (i386_record_push (&ir, 1 << (ir.dflag + 1)))
          return -1;
        break;