From: Mark Kettenis <mark.kettenis@xs4all.nl>
To: teawater@gmail.com
Cc: msnyder@vmware.com, gdb-patches@sourceware.org
Subject: Re: [RFA/RFC Prec] Add Linux AMD64 process record support second version, (instruction set support) 1/3
Date: Sun, 19 Jul 2009 21:22:00 -0000 [thread overview]
Message-ID: <200907191739.n6JHcxTR008064@brahms.sibelius.xs4all.nl> (raw)
In-Reply-To: <daef60380907191016u67d99861oeac6e5b449b512af@mail.gmail.com> (message from Hui Zhu on Mon, 20 Jul 2009 01:16:10 +0800)
> From: Hui Zhu <teawater@gmail.com>
> Date: Mon, 20 Jul 2009 01:16:10 +0800
> /* Parse the current instruction and record the values of the registers and
> memory that will be changed in current instruction to "record_arch_list".
> Return -1 if something wrong. */
>
> +#define I386_RECORD_ARCH_LIST_ADD_REG(regnum) \
> + do { \
> + if (record_arch_list_add_reg (ir.regcache, ir.regmap[(regnum)])) \
> + return -1; \
> + } while (0)
> +
Hmm, I really disklike this macro. Having that return embedded in
there is really bad.
The current implementation of record_arch_list_add_reg() always
returns 0, so I don't see why you need it.
You should make record_arch_list_add_reg().
next prev parent reply other threads:[~2009-07-19 17:39 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-07-07 2:38 Hui Zhu
2009-07-13 0:52 ` Michael Snyder
2009-07-17 8:50 ` Hui Zhu
2009-07-18 1:20 ` Michael Snyder
2009-07-19 17:21 ` Hui Zhu
2009-07-19 21:22 ` Mark Kettenis [this message]
2009-07-20 6:14 ` Hui Zhu
2009-07-20 1:39 ` Michael Snyder
2009-07-20 10:22 ` Hui Zhu
2009-07-20 14:24 ` Hui Zhu
2009-07-25 22:07 ` Michael Snyder
2009-07-27 16:50 ` Hui Zhu
2009-07-25 22:20 ` Michael Snyder
2009-07-28 11:03 ` Hui Zhu
2009-08-03 5:37 ` Hui Zhu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200907191739.n6JHcxTR008064@brahms.sibelius.xs4all.nl \
--to=mark.kettenis@xs4all.nl \
--cc=gdb-patches@sourceware.org \
--cc=msnyder@vmware.com \
--cc=teawater@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox