From: Philippe Waroquiers via Gdb-patches <gdb-patches@sourceware.org>
To: "Aktemur, Tankut Baris" <tankut.baris.aktemur@intel.com>,
Simon Marchi <simark@simark.ca>,
"gdb-patches@sourceware.org" <gdb-patches@sourceware.org>
Subject: Re: [PATCH] gdb/thread: fine-tune 'info threads' help text
Date: Mon, 19 Oct 2020 20:51:46 +0200 [thread overview]
Message-ID: <49c0cb06a55be6266e9d4400bdbf3282a45335d0.camel@skynet.be> (raw)
In-Reply-To: <SN6PR11MB2893C35C5DBB58972E0B233EC41E0@SN6PR11MB2893.namprd11.prod.outlook.com>
On Mon, 2020-10-19 at 15:57 +0000, Aktemur, Tankut Baris via Gdb-patches wrote:
> > I would put a blank line just after the "Usage:", because I like when things are well
> > visually separated. But it LGTM regardless.
>
> I agree, but I checked some other arbitrary commands manually, and also did a
> `grep -A 1 "Usage:" *.c`, and found that a great portion of commands do not print that
> separator newline. For consistency, let me push without the newline.
Some conventions/invariants regarding the command help text
are verified by command-def-selftests.c
If we want to have consistently a blank line (or consistently no blank line)
before Usage:, then that is an additional verification we can put in check_doc.
Philippe
next prev parent reply other threads:[~2020-10-19 18:51 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-19 15:32 Tankut Baris Aktemur via Gdb-patches
2020-10-19 15:39 ` Simon Marchi
2020-10-19 15:57 ` Aktemur, Tankut Baris via Gdb-patches
2020-10-19 15:59 ` Simon Marchi
2020-10-19 18:51 ` Philippe Waroquiers via Gdb-patches [this message]
2020-10-19 16:04 ` Eli Zaretskii via Gdb-patches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=49c0cb06a55be6266e9d4400bdbf3282a45335d0.camel@skynet.be \
--to=gdb-patches@sourceware.org \
--cc=philippe.waroquiers@skynet.be \
--cc=simark@simark.ca \
--cc=tankut.baris.aktemur@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox