From: Simon Marchi <simark@simark.ca>
To: Tankut Baris Aktemur <tankut.baris.aktemur@intel.com>,
gdb-patches@sourceware.org
Subject: Re: [PATCH] gdb/thread: fine-tune 'info threads' help text
Date: Mon, 19 Oct 2020 11:39:02 -0400 [thread overview]
Message-ID: <b647d30f-5e96-ac67-ee8b-4d69c1cbcdc9@simark.ca> (raw)
In-Reply-To: <1603121558-28398-1-git-send-email-tankut.baris.aktemur@intel.com>
On 2020-10-19 11:32 a.m., Tankut Baris Aktemur via Gdb-patches wrote:
> The help text of 'info threads' is below:
>
> (gdb) help info threads
> Display currently known threads.
> Usage: info threads [OPTION]... [ID]...
>
> Options:
> -gid
> Show global thread IDs.If ID is given, it is a space-separated list of IDs of threads to display.
> Otherwise, all threads are displayed.
> (gdb)
>
> I think the "If ID is given ..." info should have come right below
> the the usage line. This patch reorganizes the text so that we get
>
> (gdb) help info threads
> Display currently known threads.
> Usage: info threads [OPTION]... [ID]...
> If ID is given, it is a space-separated list of IDs of threads to display.
> Otherwise, all threads are displayed.
>
> Options:
> -gid
> Show global thread IDs.
> (gdb)
Hmm yeah, the "before" text looks erroneous.
I would put a blank line just after the "Usage:", because I like when things are well visually separated. But it LGTM regardless.
Simon
Simon
next prev parent reply other threads:[~2020-10-19 15:39 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-19 15:32 Tankut Baris Aktemur via Gdb-patches
2020-10-19 15:39 ` Simon Marchi [this message]
2020-10-19 15:57 ` Aktemur, Tankut Baris via Gdb-patches
2020-10-19 15:59 ` Simon Marchi
2020-10-19 18:51 ` Philippe Waroquiers via Gdb-patches
2020-10-19 16:04 ` Eli Zaretskii via Gdb-patches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b647d30f-5e96-ac67-ee8b-4d69c1cbcdc9@simark.ca \
--to=simark@simark.ca \
--cc=gdb-patches@sourceware.org \
--cc=tankut.baris.aktemur@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox