From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id dkftABuzjV+bSwAAWB0awg (envelope-from ) for ; Mon, 19 Oct 2020 11:39:07 -0400 Received: by simark.ca (Postfix, from userid 112) id EA10B1EDF4; Mon, 19 Oct 2020 11:39:06 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-1.0 required=5.0 tests=MAILING_LIST_MULTI autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 5454B1E4B5 for ; Mon, 19 Oct 2020 11:39:06 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id E0297388CC1B; Mon, 19 Oct 2020 15:39:05 +0000 (GMT) Received: from simark.ca (simark.ca [158.69.221.121]) by sourceware.org (Postfix) with ESMTPS id 3B1E33857C56 for ; Mon, 19 Oct 2020 15:39:03 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 3B1E33857C56 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=simark.ca Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=simark@simark.ca Received: from [172.16.0.95] (192-222-181-218.qc.cable.ebox.net [192.222.181.218]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id B19C01E4B5; Mon, 19 Oct 2020 11:39:02 -0400 (EDT) Subject: Re: [PATCH] gdb/thread: fine-tune 'info threads' help text To: Tankut Baris Aktemur , gdb-patches@sourceware.org References: <1603121558-28398-1-git-send-email-tankut.baris.aktemur@intel.com> From: Simon Marchi Message-ID: Date: Mon, 19 Oct 2020 11:39:02 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <1603121558-28398-1-git-send-email-tankut.baris.aktemur@intel.com> Content-Type: text/plain; charset=utf-8 Content-Language: tl Content-Transfer-Encoding: 7bit X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces@sourceware.org Sender: "Gdb-patches" On 2020-10-19 11:32 a.m., Tankut Baris Aktemur via Gdb-patches wrote: > The help text of 'info threads' is below: > > (gdb) help info threads > Display currently known threads. > Usage: info threads [OPTION]... [ID]... > > Options: > -gid > Show global thread IDs.If ID is given, it is a space-separated list of IDs of threads to display. > Otherwise, all threads are displayed. > (gdb) > > I think the "If ID is given ..." info should have come right below > the the usage line. This patch reorganizes the text so that we get > > (gdb) help info threads > Display currently known threads. > Usage: info threads [OPTION]... [ID]... > If ID is given, it is a space-separated list of IDs of threads to display. > Otherwise, all threads are displayed. > > Options: > -gid > Show global thread IDs. > (gdb) Hmm yeah, the "before" text looks erroneous. I would put a blank line just after the "Usage:", because I like when things are well visually separated. But it LGTM regardless. Simon Simon