From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id hMigKEfgjV9rAwAAWB0awg (envelope-from ) for ; Mon, 19 Oct 2020 14:51:51 -0400 Received: by simark.ca (Postfix, from userid 112) id 9570C1EFBF; Mon, 19 Oct 2020 14:51:51 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-1.1 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,MAILING_LIST_MULTI,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.2 Received: from sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 3D47B1EFB9 for ; Mon, 19 Oct 2020 14:51:51 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id E484A38708DB; Mon, 19 Oct 2020 18:51:50 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org E484A38708DB DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1603133510; bh=P+qYRyT74fVRh8fJvyVKV7Go4vXGY4sU/ep/3BpcXaE=; h=Subject:To:Date:In-Reply-To:References:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To: From; b=phWA3hOPQyLdmdDekzJjoJWJYKwtL5IWwa63XaPGHvgsQHn1kQrlX2GZwdaXa6j98 +MsrGUhWf4yHC5BYViQH2ZEVeP6kOy7S4TWU0rbAXI9CuA753LmeiVaSFP3sUSQsKj GP3KcjccE/PRfPcTKsOuyKwIDlksLXhEXha6ZnrA= Received: from mailsec117.isp.belgacom.be (mailsec117.isp.belgacom.be [195.238.20.113]) by sourceware.org (Postfix) with ESMTPS id 5666F386F81A for ; Mon, 19 Oct 2020 18:51:48 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 5666F386F81A IronPort-SDR: 4gUMMwyVZz9mFuc28N0H1+EJIhFWw3EauLTnt5kicWqM1Qy/MNWbKuWqdIO44kv9zfAmoT8mfZ 2poKEiEV6y6oO0lkdGeDLoF1q+dgTtsbgHZN3s1EqYd4l+HS21KhOA8s00K7k0lmbc54f4dmeE FXa8GfUVaJPFSDDnIAz9XV3GPbrtu0E7NQI0aZXEhY0CXwATZn9z/aG4/sbRQMQ4RX+FgDB41S zaqBbhKoPV1BVwa6a0tpwt+vNBLk/F82pxHzz7xJ/h+oAopDBFPJ7OBG3irG6AJo1umi82A8ak VXw= IronPort-PHdr: =?us-ascii?q?9a23=3AYHC5xBSrBh61ID4PnHR9WUEKrtpsv+yvbD5Q0Y?= =?us-ascii?q?Iujvd0So/mwa67ZRCOt8tkgFKBZ4jH8fUM07OQ7/m/HzNZqs/b7zgrS99lb1?= =?us-ascii?q?c9k8IYnggtUoauKHbQC7rUVRE8B9lIT1R//nu2YgB/Ecf6YEDO8DXptWZBUh?= =?us-ascii?q?rwOhBoKevrB4Xck9q41/yo+53Ufg5EmCexbal9IRmrrwjdrMsbjZZtJqos1B?= =?us-ascii?q?fEoGZDdvhLy29vOV+dhQv36N2q/J5k/SRQuvYh+NBFXK7nYak2TqFWASo/PW?= =?us-ascii?q?wt68LlqRfMTQ2U5nsBSWoWiQZHAxLE7B7hQJj8tDbxu/dn1ymbOc32Sq00WS?= =?us-ascii?q?in4qx2RhLklDsLOjgk+2zMlMd+kLxUrw6gpxxnwo7bfoeVNOZlfqjAed8WXH?= =?us-ascii?q?dNUtpNWyBEBI63cokBAPcbPetArIfzulsAowWwCwauCuPg1jFHiXD506Ahz+?= =?us-ascii?q?QsExvL0BA8E98UsnnZqsj+OqcIUeCyyanF1S/Nb/NX2Tf56YjIagghru+RVr?= =?us-ascii?q?1wa8XR004vFxrYjlWRt4PlJSiV3fkKvmiD7+pgVOavi28/qwFpvDej3MkthZ?= =?us-ascii?q?PThoIS01DE6CR5z5gvJd2jU0N7et2kEZtWty6EK4t6WNgtTH9xtSs817YJto?= =?us-ascii?q?K1cjIQx5Q72x7QdeaHc46Q7x79SuqcIit1iX15dL6jhRu/8Uetx/D8WMWo31?= =?us-ascii?q?tEoSpLn8TCu30JyRHd5NaKR/V+80qi1zuC1gDe5+9LLE0wlKfWLYMqzL0olp?= =?us-ascii?q?cLr0jPAy37lF/rgKKYd0go4Oul5/n9brjoqJKRMZJ/hBvkPaQ0gMO/BPw1Mg?= =?us-ascii?q?0JX2eG5+uxzKbj/UjlQLVSif02j7XZvIjaJcsFoq65BBdY0oM+5BqnDjem1s?= =?us-ascii?q?oXnWUfIV5bZR6KjZLlN0zALf35F/uygEmgnC1lyv3IJrHhB4/CLnnHkLfvZ7?= =?us-ascii?q?Z97EtcxRIrzdBf5pJUDrABIOrrWkDvrtDZAAU2Mxazw+b+FdV9150RWXiUAq?= =?us-ascii?q?KCK6PSsl+J5uQxLOmQfoMaoyjyJ+A/5/HylX85hUMdfa6x0JsLcn+4GPdmI1?= =?us-ascii?q?iFYXb2mdgOC30KvgslTODwklKCUiJTaGi3X6Ih/DE2E4OmDYHfRo+zhLyNxj?= =?us-ascii?q?u0HppTZmpeEFCDDW/od5mYW/cLcC+SOc5hkjkeWri7SI8szgqutA7/y7V9NO?= =?us-ascii?q?rU+TcUuo7529Jt/e3ciQky9SBoD8Say2yNQHx7kXgRSz8uxq9/vVByyled3q?= =?us-ascii?q?hjmPFYDttT5+5TUggmK5HdwfZ1C8rsVQ7bedeJUlmmEZ2aBmR7Z9EtztoTeQ?= =?us-ascii?q?I1J9ykjQ3flwCjGb4O3fTfGJUy8b/AmXL4PcdmjX/FyKQkkkMOQ81TOGngja?= =?us-ascii?q?l6oUybPI/MlEPRsq+wfqQdlHrW9WKK12mmp0BdWRRzF67MCzRXLETap5Hh71?= =?us-ascii?q?/JT7K1Ia8gLxFKxNGLMKYMbcfmxx0SS/vpfczXf2mxlnyYHhGV3LiBc4Pwdi?= =?us-ascii?q?MaxiqLW2YelAVGxXaHMQkmHirpnGvECyVzFF/1eAu46el/rHKjVkJy0AiQaF?= =?us-ascii?q?R81rev4TYOhu2aRu9V1L9S63RpkCl9AFvoh4GeMNGHvQc0OfwEOd4=3D?= X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: =?us-ascii?q?A2C4BgBF341f/yFRiNlgHAEBAQEBAQc?= =?us-ascii?q?BARIBAQQEAQFAB4FIAoNthRyJBYgUmimBfAsBAQEBAQEBAQEJLAECBAEBhEA?= =?us-ascii?q?KAoIOJjoEDQIDAQEBAwIFAQEGAQEBAQEBBQQBhhRFgjcpAYMSAQUjMzMIAxg?= =?us-ascii?q?CAiYCAlcGAYY5r2CBMoVYg0qBQoEOKokkhCGBTT+BEYMQPodUgl8EnBybMys?= =?us-ascii?q?Hgm2BDwQLmVMioVCOB4UqoFWBbQGBd22DPU8mjisXjiZCaAIGCgEBAwl0CBO?= =?us-ascii?q?NOQEB?= X-IPAS-Result: =?us-ascii?q?A2C4BgBF341f/yFRiNlgHAEBAQEBAQcBARIBAQQEAQFAB?= =?us-ascii?q?4FIAoNthRyJBYgUmimBfAsBAQEBAQEBAQEJLAECBAEBhEAKAoIOJjoEDQIDA?= =?us-ascii?q?QEBAwIFAQEGAQEBAQEBBQQBhhRFgjcpAYMSAQUjMzMIAxgCAiYCAlcGAYY5r?= =?us-ascii?q?2CBMoVYg0qBQoEOKokkhCGBTT+BEYMQPodUgl8EnBybMysHgm2BDwQLmVMio?= =?us-ascii?q?VCOB4UqoFWBbQGBd22DPU8mjisXjiZCaAIGCgEBAwl0CBONOQEB?= Received: from 33.81-136-217.adsl-dyn.isp.belgacom.be (HELO md) ([217.136.81.33]) by relay.skynet.be with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 19 Oct 2020 20:51:47 +0200 Message-ID: <49c0cb06a55be6266e9d4400bdbf3282a45335d0.camel@skynet.be> Subject: Re: [PATCH] gdb/thread: fine-tune 'info threads' help text To: "Aktemur, Tankut Baris" , Simon Marchi , "gdb-patches@sourceware.org" Date: Mon, 19 Oct 2020 20:51:46 +0200 In-Reply-To: References: <1603121558-28398-1-git-send-email-tankut.baris.aktemur@intel.com> Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.30.5-1.1 MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Philippe Waroquiers via Gdb-patches Reply-To: Philippe Waroquiers Errors-To: gdb-patches-bounces@sourceware.org Sender: "Gdb-patches" On Mon, 2020-10-19 at 15:57 +0000, Aktemur, Tankut Baris via Gdb-patches wrote: > > I would put a blank line just after the "Usage:", because I like when things are well > > visually separated. But it LGTM regardless. > > I agree, but I checked some other arbitrary commands manually, and also did a > `grep -A 1 "Usage:" *.c`, and found that a great portion of commands do not print that > separator newline. For consistency, let me push without the newline. Some conventions/invariants regarding the command help text are verified by command-def-selftests.c If we want to have consistently a blank line (or consistently no blank line) before Usage:, then that is an additional verification we can put in check_doc. Philippe