Re: [PATCH] gdb/thread: fine-tune 'info threads' help text

Simon Marchi
2020-10-19T15:39:07Z

On 2020-10-19 11:32 a.m., Tankut Baris Aktemur via Gdb-patches wrote:
> The help text of 'info threads' is below:
>
> (gdb) help info threads
> Display currently known threads.
> Usage: info threads [OPTION]... [ID]...
>
> Options:
> -gid
> Show global thread IDs.If ID is given, it is a space-separated list of IDs of threads to display.
> Otherwise, all threads are displayed.
> (gdb)
>
> I think the "If ID is given ..." info should have come right below
> the the usage line. This patch reorganizes the text so that we get
>
> (gdb) help info threads
> Display currently known threads.
> Usage: info threads [OPTION]... [ID]...
> If ID is given, it is a space-separated list of IDs of threads to display.
> Otherwise, all threads are displayed.
>
> Options:
> -gid
> Show global thread IDs.
> (gdb)

Hmm yeah, the "before" text looks erroneous.

I would put a blank line just after the "Usage:", because I like when things are well visually separated. But it LGTM regardless.

Simon

Simon