Re: [PATCH][gdbserver] Check for sys/dir.h and sys.user.h in configuration.

["Doug Kwan (關振德)" <dougkwan@google.com>]

Hi,

2008/7/25 Daniel Jacobowitz <drow@false.org>:

> Just one question: if removing sys/user.h and sys/dir.h doesn't break
> anything on android, does it break anything on other GNU/Linux
> targets?

Android is not quite Linux.  The C library is not glibc so what works
on Android may not work on a GNU/Linux system. I don't know if that
works for all GNU/Linux but I tried an ubuntu system and gdbserver
built correctly for the target i686-unknown-linux-gnu.  So the headers
may be unncessary but I cannot say this for all Linux distributions.

> Removing the errno declaration is fine.  Removing the includes is fine
> if they're not actually necessary, otherwise this patch is OK.

My patch does not remove the includes unconditionally.  Are you
suggesting I should just remove the includes?  If so, I don't need to
change configure.ac and other related files.

-Doug