From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 6383 invoked by alias); 25 Jul 2008 22:54:12 -0000 Received: (qmail 6374 invoked by uid 22791); 25 Jul 2008 22:54:12 -0000 X-Spam-Check-By: sourceware.org Received: from smtp-out.google.com (HELO smtp-out.google.com) (216.239.33.17) by sourceware.org (qpsmtpd/0.31) with ESMTP; Fri, 25 Jul 2008 22:53:45 +0000 Received: from wpaz21.hot.corp.google.com (wpaz21.hot.corp.google.com [172.24.198.85]) by smtp-out.google.com with ESMTP id m6PMrbEM028247 for ; Fri, 25 Jul 2008 23:53:37 +0100 Received: from rv-out-0506.google.com (rvbk40.prod.google.com [10.140.87.40]) by wpaz21.hot.corp.google.com with ESMTP id m6PMrZ2k017790 for ; Fri, 25 Jul 2008 15:53:36 -0700 Received: by rv-out-0506.google.com with SMTP id k40so2982280rvb.17 for ; Fri, 25 Jul 2008 15:53:35 -0700 (PDT) Received: by 10.141.153.16 with SMTP id f16mr1131607rvo.252.1217026415370; Fri, 25 Jul 2008 15:53:35 -0700 (PDT) Received: by 10.140.248.15 with HTTP; Fri, 25 Jul 2008 15:53:35 -0700 (PDT) Message-ID: <498552560807251553q50a117a4qf4879a9b4694bfd3@mail.gmail.com> Date: Fri, 25 Jul 2008 22:54:00 -0000 From: "=?BIG5?B?RG91ZyBLd2FuICjD9q62vHcp?=" To: "=?BIG5?B?RG91ZyBLd2FuICjD9q62vHcp?=" , "Thiago Jung Bauermann" , "Michael Snyder" , gdb-patches@sourceware.org Subject: Re: [PATCH][gdbserver] Check for sys/dir.h and sys.user.h in configuration. In-Reply-To: <20080725214142.GA18480@caradoc.them.org> MIME-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Content-Disposition: inline References: <498552560807221759w1ade0ec2jd63c12475ddb5217@mail.gmail.com> <1216784910.3549.496.camel@localhost.localdomain> <1216821712.5922.8.camel@localhost.localdomain> <20080723143258.GA12421@caradoc.them.org> <498552560807231014q317b59bai907c4cf9f9009f6e@mail.gmail.com> <20080725214142.GA18480@caradoc.them.org> Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2008-07/txt/msg00461.txt.bz2 Hi, 2008/7/25 Daniel Jacobowitz : > Just one question: if removing sys/user.h and sys/dir.h doesn't break > anything on android, does it break anything on other GNU/Linux > targets? Android is not quite Linux. The C library is not glibc so what works on Android may not work on a GNU/Linux system. I don't know if that works for all GNU/Linux but I tried an ubuntu system and gdbserver built correctly for the target i686-unknown-linux-gnu. So the headers may be unncessary but I cannot say this for all Linux distributions. > Removing the errno declaration is fine. Removing the includes is fine > if they're not actually necessary, otherwise this patch is OK. My patch does not remove the includes unconditionally. Are you suggesting I should just remove the includes? If so, I don't need to change configure.ac and other related files. -Doug